Move images & generate thumbnails #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyngit
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Great! It might be smart to use the exact same strategy in the page-header.html template. The banner images that are currently used in this template are already optimized for this purpose - they are the right size and have the right aspect ratio for this purpose. However, I can imagine a content editor uploading a new banner image that is much too large for this purpose, which would make the page load time quite slow. It would be easy to add the same image processing to the template to re-size the banner image if it's too large.
robyngit
approved these changes
Jun 21, 2021
ThomasThelen
force-pushed
the
restructure_images
branch
from
dde7f24 to
4800695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not a whole lot to look at here.
Fixes #27 and partially #22
Changes
Removed card_image from Frontmatter
One change you'll see is that card_image no longer exists. Instead, Hugo's image processing is used to generate the card images. The other relevant change for this is in
layouts/partials/cards.html. I still didn't removeimages/from the banner paths; I still don't know if it'll be more confusing or not for anyone using this, but it's not a problem at the moment.Image Directories
The images have been moved to new directories and bg_image have been updated to reflect this.