Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use datediff/dateadd macro #79

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

lawrenceadams
Copy link
Collaborator

@lawrenceadams lawrenceadams commented Oct 6, 2024

  • various sql engines do not allow interval extraction from delta (as deltas are passed as numeric types); concretely: snowflake, likely others
  • use the dbt standard datediff/dateadd macro to open up possibility to other sql engines
  • arguably more idiomatic
  • bring in line with other recent changes by @katy-sadowski

 - various sql engines do not allow interval extraction from delta (as deltas are passed as numeric types); concretely: snowflake, likely others
 - use the dbt standard datediff macro to open up possibility to other sql engines
 - arguably more idiomatic
 - bring in line with other recent changes by @katy-sadowski
@lawrenceadams lawrenceadams changed the title refactor: use datediff macro over extracting day from timedelta refactor: use datediff/dateadd macro Oct 6, 2024
 - probably not necessary but keep uniform
Copy link
Collaborator

@katy-sadowski katy-sadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lawrenceadams lawrenceadams merged commit 415130d into main Oct 7, 2024
@lawrenceadams lawrenceadams deleted the lawrenceadams-use-datediff-over-extract branch October 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants