fix

src/main/java/org/ohdsi/circe/check/checkers/ExitCriteriaDaysOffsetCheck.java

@@ -22,8 +22,6 @@
 import org.ohdsi.circe.cohortdefinition.CohortExpression;
 import org.ohdsi.circe.cohortdefinition.DateOffsetStrategy;
 
-import java.util.Arrays;
-import java.util.List;
 import java.util.Objects;
 
 import static org.ohdsi.circe.check.operations.Operations.match;
@@ -43,9 +41,9 @@ protected WarningSeverity defineSeverity() {
     protected void check(CohortExpression expression, WarningReporter reporter) {
 
         match(expression.endStrategy)
-            .isA(DateOffsetStrategy.class)
-            .then(s -> match((DateOffsetStrategy)s)
-                .when(dateOffsetStrategy -> Objects.equals(StartDate, dateOffsetStrategy.dateField) &&  0 == dateOffsetStrategy.offsetUnitValue)
-                .then(dateOffsetStrategy -> reporter.add(String.format(DAYS_OFFSET_WARNING, dateOffsetStrategy.offsetUnit))));
+                .isA(DateOffsetStrategy.class)
+                .then(s -> match((DateOffsetStrategy)s)
+                  .when(dateOffsetStrategy -> Objects.equals(StartDate, dateOffsetStrategy.dateField) &&  (0 == dateOffsetStrategy.offsetUnitValue || 0 == dateOffsetStrategy.offset))
+                  .then(dateOffsetStrategy -> reporter.add(String.format(DAYS_OFFSET_WARNING, dateOffsetStrategy.offsetUnit))));
     }
 }

src/main/java/org/ohdsi/circe/check/checkers/FirstTimeInHistoryCheck.java

@@ -42,10 +42,10 @@ protected void checkCriteria(CorelatedCriteria criteria, String groupName, Warni
         String name = CriteriaNameHelper.getCriteriaName(criteria.criteria) + " at " + groupName;
         Execution addWarning = () -> reporter.add(WARNING, name);
         match(criteria)
-            .when(c -> c.startWindow != null && ((c.startWindow.start != null && c.startWindow.start.days  != null)
-                || (c.startWindow.end != null && c.startWindow.end.days  != null))
-                || c.startWindow != null && (( c.startWindow.start != null && c.startWindow.start.timeUnitValue != null)
-                || (c.startWindow.end != null) && c.startWindow.end.timeUnitValue != null))
+                .when(c -> c.startWindow != null && ((c.startWindow.start != null && c.startWindow.start.days != null)
+                        || (c.startWindow.end != null && c.startWindow.end.days != null))
+                        || c.startWindow != null && ((c.startWindow.start != null && c.startWindow.start.timeUnitValue != null)
+                        || (c.startWindow.end != null) && c.startWindow.end.timeUnitValue != null))
                 .then(cc -> match(cc.criteria)
                         .isA(ConditionEra.class)
                         .then(c -> match((ConditionEra)c)

src/main/java/org/ohdsi/circe/cohortdefinition/CustomEraStrategy.java

@@ -18,12 +18,14 @@
  */
 package org.ohdsi.circe.cohortdefinition;
 
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
 
 /**
  *
  * @author Chris Knoll <[email protected]>
  */
+@JsonIgnoreProperties(ignoreUnknown = true)
 public class CustomEraStrategy  extends EndStrategy {
 
   @JsonProperty("DrugCodesetId")
@@ -32,17 +34,19 @@ public class CustomEraStrategy  extends EndStrategy {
   @JsonProperty("GapDays")
   public int gapDays = 0;
   @JsonProperty("GapUnit")
-  public String gapUnit = "day";
+  public String gapUnit = IntervalUnit.DAY.getName();;
   @JsonProperty("GapUnitValue")
-  public int gapUnitValue = 0;
+  public Integer gapUnitValue = null;
 
   @JsonProperty("Offset")
   public int offset = 0;
   @JsonProperty("OffsetUnit")
-  public String offsetUnit = "day";
+  public String offsetUnit = IntervalUnit.DAY.getName();;
   @JsonProperty("OffsetUnitValue")
   public int offsetUnitValue = 0;
 
+
+
   @JsonProperty("DaysSupplyOverride")
   public Integer daysSupplyOverride = null;
 

src/main/java/org/ohdsi/circe/cohortdefinition/DateOffsetStrategy.java

@@ -27,22 +27,24 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class DateOffsetStrategy extends EndStrategy {
 
-  @JsonProperty("Offset")
-  public int offset = 0;
+  public enum DateField {
+    StartDate,
+    EndDate
+  }
+
   @JsonProperty("DateField")
   public DateField dateField = DateField.StartDate;
+
+  @JsonProperty("Offset")
+  public int offset = 0;
+
+  @JsonProperty("OffsetUnit")
+  public String offsetUnit = IntervalUnit.DAY.getName();;
   @JsonProperty("OffsetUnitValue")
   public int offsetUnitValue = 0;
-  @JsonProperty("OffsetUnit")
-  public String offsetUnit = "day";
 
   @Override
   public String accept(IGetEndStrategySqlDispatcher dispatcher, String eventTable) {
     return dispatcher.getStrategySql(this, eventTable);
   }
-
-  public enum DateField {
-    StartDate,
-    EndDate
-  }
 }

src/main/java/org/ohdsi/circe/cohortdefinition/Window.java

@@ -27,25 +27,30 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class Window {
 
-  @JsonProperty("Start")
-  public Endpoint start;
-  @JsonProperty("End")
-  public Endpoint end;
-  @JsonProperty("UseIndexEnd")
-  public Boolean useIndexEnd;
-  @JsonProperty("UseEventEnd")
-  public Boolean useEventEnd;
-
+  @JsonIgnoreProperties(ignoreUnknown = true)
   public static class Endpoint {
-
     @JsonProperty("Days")
     public Integer days;
+
+    @JsonProperty("Coeff")
+    public int coeff;
     @JsonProperty("TimeUnitValue")
     public Integer timeUnitValue;
+
     @JsonProperty("TimeUnit")
-    public String timeUnit = "day";
+    public String timeUnit = IntervalUnit.DAY.getName();
+	}
+
+  @JsonProperty("Start")
+  public Endpoint start;  
 
-    @JsonProperty("Coeff")
-    public int coeff;
-  }
+  @JsonProperty("End")
+  public Endpoint end;  
+
+	@JsonProperty("UseIndexEnd")
+	public Boolean useIndexEnd;
+
+	@JsonProperty("UseEventEnd")
+	public Boolean useEventEnd;
+
 }

src/main/resources/resources/cohortdefinition/sql/dateOffsetStrategy.sql

@@ -1,9 +1,6 @@
 -- date offset strategy
 
-select event_id,
-       person_id,
-       case
-           when DATEADD(@offsetUnit, @offsetUnitValue, @dateField) > op_end_date then op_end_date
-           else DATEADD(@offsetUnit, @offsetUnitValue, @dateField) end as end_date
+select event_id, person_id, 
+  case when DATEADD(@offsetUnit,@offsetUnitValue,@dateField) > op_end_date then op_end_date else DATEADD(@offsetUnit,@offsetUnitValue,@dateField) end as end_date
 INTO #strategy_ends
 from @eventTable;

src/main/resources/resources/cohortdefinition/sql/generateCohort.sql

@@ -62,8 +62,8 @@ from ( --cteEnds
 	FROM #cohort_rows c
 	JOIN ( -- cteEndDates
     SELECT
-      person_id,
-      DATEADD(@era_pad_unit, -1 * @eraconstructorpad, event_date)  as end_date
+      person_id
+      , DATEADD(@eraPadUnit,-1 * @eraPadValue, event_date)  as end_date
     FROM
     (
       SELECT
@@ -83,7 +83,7 @@ from ( --cteEnds
 
         SELECT
           person_id
-          , DATEADD(@era_pad_unit, -1 * @eraconstructorpad, end_date)  as end_date
+          , DATEADD(@eraPadUnit,@eraPadValue,end_date) as end_date
           , 1 AS event_type
         FROM #cohort_rows
       ) RAWDATA

src/test/java/org/ohdsi/circe/check/checkers/ComparisonsTest.java

@@ -137,7 +137,57 @@ public void compareTo() {
 
         assertEquals(5, Comparisons.compareTo(filter, window));
     }
-
+    @Test
+    public void compareToHours(){
+      ObservationFilter filter = new ObservationFilter();
+      filter.postDays = 10;
+      filter.priorDays = 5;
+      Window window = new Window();
+      window.start = new Window.Endpoint();
+      window.end = new Window.Endpoint();
+      window.start.timeUnit = "hour";
+      window.start.timeUnitValue = 72;
+      window.start.coeff = -1;
+
+      window.end.timeUnit = "hour";
+      window.end.timeUnitValue = 120;
+      window.end.coeff = 1;
+      assertEquals(604800, Comparisons.compareTo(filter, window));
+    }
+  @Test
+  public void compareToMinute() {
+    ObservationFilter filter = new ObservationFilter();
+    filter.postDays = 10;
+    filter.priorDays = 5;
+    Window window = new Window();
+    window.start = new Window.Endpoint();
+    window.end = new Window.Endpoint();
+    window.start.timeUnit = "minute";
+    window.start.timeUnitValue = 30;
+    window.start.coeff = -1;
+
+    window.end.timeUnit = "minute";
+    window.end.timeUnitValue = 75;
+    window.end.coeff = 1;
+    assertEquals(1289700, Comparisons.compareTo(filter, window));
+    }
+  @Test
+  public void compareToSecond() {
+    ObservationFilter filter = new ObservationFilter();
+    filter.postDays = 10;
+    filter.priorDays = 5;
+    Window window = new Window();
+    window.start = new Window.Endpoint();
+    window.end = new Window.Endpoint();
+    window.start.timeUnit = "second";
+    window.start.timeUnitValue = 30;
+    window.start.coeff = -1;
+
+    window.end.timeUnit = "second";
+    window.end.timeUnitValue = 75;
+    window.end.coeff = 1;
+    assertEquals(1295895, Comparisons.compareTo(filter, window));
+  }
     @Test
     public void compareToHours() {
         ObservationFilter filter = new ObservationFilter();

src/test/java/org/ohdsi/circe/check/checkers/DeathTimeWindowCheckTest.java

@@ -31,9 +31,9 @@ public void checkCorrect() {
         List<Warning> warnings = check.check(CORRECT_EXPRESSION);
         assertEquals(0, warnings.size());
     }
-    @Test
-    public void checkCorrectSecond() {
-        List<Warning> warnings = check.check(CORRECT_EXPRESSION_SECOND);
-        assertEquals(0, warnings.size());
-    }
+  @Test
+  public void checkCorrectSecond() {
+    List<Warning> warnings = check.check(CORRECT_EXPRESSION_SECOND);
+    assertEquals(0, warnings.size());
+  }
 }

src/test/java/org/ohdsi/circe/cohortdefinition/printfriendly/PrintFriendlyTest.java

@@ -485,7 +485,7 @@ public void customEraExitTestSecond() {
         ));
 
     }
-  
+
   @Test
   public void conceptSetSimpleTest() {
     CohortExpression expression = CohortExpression.fromJson(ResourceHelper.GetResourceAsString("/printfriendly/conceptSet_simple.json"));
@@ -671,7 +671,7 @@ public void nullConceptSetListTest() {
     pf.renderConceptSetList((ConceptSet[])null);
 
   }
-  
+
   @Test
   public void dateAdjustTest() {
     CohortExpression expression = CohortExpression.fromJson(ResourceHelper.GetResourceAsString("/printfriendly/dateAdjust.json"));
@@ -690,16 +690,16 @@ public void dateAdjustTest() {
             "12. visit occurrences of 'Concept Set 1', starting 10 days after and ending 20 days after the event start date.",
             "13. visit details of 'Concept Set 1', starting 10 days after and ending 20 days after the event start date."
     ));
-    
+
   }
-  
+
   @Test
   public void emptyConceptListTest() {
     CohortExpression expression = CohortExpression.fromJson(ResourceHelper.GetResourceAsString("/printfriendly/emptyConceptList.json"));
     String markdown = pf.renderCohort(expression);
     assertThat(markdown, stringContainsInOrder(
             "1. condition occurrences of 'Concept Set 1', a provider specialty that is: [none specified]; a visit occurrence that is: [none specified]."
     ));
-    
+
   }
 }