Replace -x with fabs(x) due to odd breaking Linux behavior #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the erf() function, my code was getting hanging on this statement
due to
-x
not being successfully passed into the recursive call (i.e. it was still negative).Both
and
work, as did changing the implementation back to the
scipy.special
one.Also noting that the following did not work.
This PR implements
fabs()
approach to fix the issue. It was chosen after discussion with @aki-nishimura for simplicity and to avoid any potential other issues with doing a -1 multiplication.This problem occurred in the following environments:
It worked fine for me on windows 10 and all OS's pass on Github Actions, where ubuntu-20.04 is currently the latest supported linux version.
Exact root cause of this issue has not been investigated.