Entity sequence #329
Entity sequence #329
Conversation
|
Noting that this is being tested by @pavgra and team on Oracle with sample data to ensure the entity sequencing does not trash any existing data. |
| SELECT setval('${ohdsiSchema}.concept_set_item_sequence', coalesce(max(concept_set_item_id), 1)) FROM ${ohdsiSchema}.concept_set_item; | ||
|
|
||
| -- concept_set_negative_controls_sequence already exists - no need to create | ||
| SELECT setval('${ohdsiSchema}.concept_set_negative_controls_sequence', coalesce(max(id), 1)) FROM ${ohdsiSchema}.concept_set_negative_controls; |
There was a problem hiding this comment.
@wivern - I guess 'negative_controls_sequence'- not 'concept_set_negative_controls_sequence'?
|
@anthonysena, @pavgra, @wivern - I added some fixes after testing the oracle migration, it would be great if you review them. Also pay attention to the attached file with the states of the modified tables (before and after the migration). |
|
@anthonysena, if you agree with changes and there are no questions - let's merge the pull request:) |
|
@mpozhidaeva these changes look good from my side - thanks for including the before/after states for the tables impacted by this change. Since I opened this PR (based on the work your team did in the other fork) can you approve? I'll then get it merged into master. Thanks! |
Continuation of work from @wivern as part of #324.
Add fix for Flyway migration for PostgreSQL. With this fix applied, the changes look good from my side for PostgreSQL. I've also added a commit to address a regression in another SQL Server flyway script for dropping the password/salt fields for the sec_user table per @chrisknoll's issue raised on: #327 (review)
Tagging @chen-regen for awareness and help testing on Oracle.