Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.0 #79

Merged
merged 44 commits into from
Jun 24, 2020
Merged

Release 1.3.0 #79

merged 44 commits into from
Jun 24, 2020

Conversation

MaximMoinat
Copy link
Collaborator

New features

Fixes

Maxim Moinat added 30 commits January 6, 2020 12:21
Export unapproved mappings
Fix for applying previous mapping
@MaximMoinat MaximMoinat requested a review from blootsvoets June 21, 2020 20:00
Copy link
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request looks fine to me. From the code you've touched, I see a lot of room for improving the general structure of the application. I don't mind if that is postponed to another release, but it would be very good to address, rather than building on top of the existing structure.

src/org/ohdsi/usagi/ReadCodeMappingsFromFile.java Outdated Show resolved Hide resolved
src/org/ohdsi/usagi/ui/AboutDialog.java Outdated Show resolved Hide resolved
src/org/ohdsi/usagi/ui/DataChangeListener.java Outdated Show resolved Hide resolved
src/org/ohdsi/usagi/ui/ExportSourceToConceptMapDialog.java Outdated Show resolved Hide resolved
src/org/ohdsi/usagi/ui/ExportSourceToConceptMapDialog.java Outdated Show resolved Hide resolved
src/org/ohdsi/usagi/ui/UsagiMain.java Show resolved Hide resolved
src/org/ohdsi/usagi/ui/UsagiMain.java Show resolved Hide resolved
@MaximMoinat MaximMoinat merged commit 7f0fb49 into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-1.3.0 branch June 24, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants