Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

measurement table v5.0.1 vs 5.2 - column measurement_time #132

Closed
vojtechhuser opened this issue Oct 26, 2017 · 1 comment
Closed

measurement table v5.0.1 vs 5.2 - column measurement_time #132

vojtechhuser opened this issue Oct 26, 2017 · 1 comment
Labels
Bug

Comments

@vojtechhuser
Copy link
Collaborator

vojtechhuser commented Oct 26, 2017 •
edited
Loading

While using the old ETL for mimic2, I noticed that version 5 had at some point column measurement_time in the DDL.
See here:
https://github.com/OHDSI/CommonDataModel/blob/v5-historical/PostgreSQL/OMOP%20CDM%20ddl%20-%20PostgreSQL.sql#L406

The latest 5.2 does not have that column at all.
So this makes it not backwards compatible

Fix: add column measurement_time into latest CDM.
(somehow it got out) (or maybe it was done intentionally)

It is not following the same pattern as other tables.
_date
_time
_datetime

p.s.
I wish more people has rights to assign Label to an issue. (not just Claire)....
clairblacketer added a commit that referenced this issue Nov 9, 2017
@clairblacketer
Addresses #64, #70, #79, #92, #120, #132, #131 in code, documentation…
afd9a52 
… is still being updated to reflect these changes.
@clairblacketer clairblacketer mentioned this issue Jan 3, 2018
Merged
@clairblacketer
Copy link
Contributor

similar to issue #150, measurement_time needs to be added to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vojtechhuser @clairblacketer