[Vk] Don't stall in VulkanRenderSystem::destroyVkResources0() when de…

…vice is lost. Also, RenderQueue::mUsedIndirectBuffers could be non empty after device lost.
OGRECave · Dec 30, 2024 · 16a9c7b · 16a9c7b
1 parent 62eff2c
commit 16a9c7b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/OgreMain/src/OgreRenderQueue.cpp b/OgreMain/src/OgreRenderQueue.cpp
@@ -124,19 +124,20 @@ namespace Ogre
     //-----------------------------------------------------------------------
     void RenderQueue::_releaseManualHardwareResources()
     {
-        assert( mUsedIndirectBuffers.empty() );
-
-        IndirectBufferPackedVec::const_iterator itor = mFreeIndirectBuffers.begin();
-        IndirectBufferPackedVec::const_iterator endt = mFreeIndirectBuffers.end();
-
-        while( itor != endt )
+        for( IndirectBufferPacked *buf : mUsedIndirectBuffers )
         {
-            if( ( *itor )->getMappingState() != MS_UNMAPPED )
-                ( *itor )->unmap( UO_UNMAP_ALL );
-            mVaoManager->destroyIndirectBuffer( *itor );
-            ++itor;
+            if( buf->getMappingState() != MS_UNMAPPED )
+                buf->unmap( UO_UNMAP_ALL );
+            mVaoManager->destroyIndirectBuffer( buf );
         }
+        mUsedIndirectBuffers.clear();
 
+        for( IndirectBufferPacked *buf : mFreeIndirectBuffers )
+        {
+            if( buf->getMappingState() != MS_UNMAPPED )
+                buf->unmap( UO_UNMAP_ALL );
+            mVaoManager->destroyIndirectBuffer( buf );
+        }
         mFreeIndirectBuffers.clear();
     }
     //-----------------------------------------------------------------------

diff --git a/RenderSystems/Vulkan/src/OgreVulkanRenderSystem.cpp b/RenderSystems/Vulkan/src/OgreVulkanRenderSystem.cpp
@@ -404,7 +404,8 @@ namespace Ogre
         mCurrentAutoParamsBufferPtr = 0;
         mCurrentAutoParamsBufferSpaceLeft = 0;
 
-        mDevice->stall();
+        if( !mDevice->isDeviceLost() )
+            mDevice->stall();
     }
     //-------------------------------------------------------------------------
     void VulkanRenderSystem::destroyVkResources1()