move static defines to config.h #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sylensky
force-pushed
the
feature/project-configuration
branch
from
7b064cd to
0b1db89
Compare
Move settings to config.h to have one single file for static configuration values.
Generate the compile_commands.json for the clangd language server. This bears the feature to highlight variable types and allows stepping into library code.
Instead of statically assigning the sidereal tracking rate leave it to the project configuration and the user to pick the tracking rate.
Sylensky
force-pushed
the
feature/project-configuration
branch
from
0b1db89 to
34179de
Compare
Th0MmyS
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variables were statically defined in the firmware.ino.
Moved them to the
config.hand additionally expand the build environment inplatformio.iniwith those values.On top of that let platformio build the
compile_commands.jsonfor all of those that use theclangextension in vscode to step into libraries and provide code highlightings.Requires #29 #30 #36