Make initrd-flash support more configurable #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move common settings from SoC-specific includes to tegra-common.inc * Avoid direct :append to INITRAMFS_FSTYPES * Use ?= instead of hard = for more settings * Use separate variable for initrd-flash initrafms fstype Signed-off-by: Matt Madison <[email protected]>
The initrd-flash kernel/initrd image has to be the Android (cboot-style) image type, and now that we have a separate variable in the machine configs to specify that, use that variable to set INITRAMFS_FSTYPES in the recipe. Signed-off-by: Matt Madison <[email protected]>
Make the image dependencies and inclusion of the initrd-flash image conditional on whether TEGRAFLASH_INITRD_FLASH_IMAGE is non-null. This allows users to exclude initrd-flash support from their builds, if desired. Signed-off-by: Matt Madison <[email protected]>
|
This should solve a couple of issues and with it in place we can chose the initrd types for other images that may exist and use the one specified in this layer for flashing |
|
Thanks @madisongh. |
ichergui
approved these changes
Jan 17, 2023
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Jan 20, 2023
TEGRA_INITRAMFS_FSTYPES it been introduced to avoid changing the global INITRAMFS_FSTYPES that affects any recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Jan 20, 2023
TEGRA_INITRAMFS_FSTYPES it been introduced to avoid changing the global INITRAMFS_FSTYPES that affects every recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Jan 20, 2023
TEGRA_INITRAMFS_FSTYPES it's been introduced to avoid changing the global INITRAMFS_FSTYPES that affects every recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jan 20, 2023
TEGRA_INITRAMFS_FSTYPES it's been introduced to avoid changing the global INITRAMFS_FSTYPES that affects every recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
added a commit
to quaresmajose/meta-lmp
that referenced
this pull request
Jan 23, 2023
TEGRA_INITRAMFS_FSTYPES it's been introduced to avoid changing the global INITRAMFS_FSTYPES that affects every recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
ricardosalveti
pushed a commit
to foundriesio/meta-lmp
that referenced
this pull request
Jan 23, 2023
TEGRA_INITRAMFS_FSTYPES it's been introduced to avoid changing the global INITRAMFS_FSTYPES that affects every recipe. OE4T/meta-tegra#1140 Signed-off-by: Jose Quaresma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some global settings so that distros/users that want to use an alternative initrd-flash image, or exclude that support altogether to cut down on build times, can do so.
TEGRAFLASH_INITRD_FLASH_IMAGEcan be set to the null string to exclude support, or to the name of another recipe.Also refactor some more common settings to
tegra-common.inc, and avoid direct appends toINITRAMFS_IMAGE_FSTYPES, allowing users to specify alternative types for their initramfs builds by settingTEGRA_INITRAMFS_FSTYPES(andTEGRA_INITRD_FLASH_INITRAMFS_FSTYPESfor the initrd flasher).