Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CompositionService #1077

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Remove CompositionService #1077

merged 2 commits into from
Jan 20, 2023

Conversation

sunithasomanna
Copy link
Collaborator

Removed compostitionservice instances from the GS readme. Updated the relevant image.

@sunithasomanna sunithasomanna added prio:normal normal priority, can be taken up after high priority issues are addressed status:in-progress issue has been accepted previously and now taken up for implementation type:doc This tag is for documentation labels Jan 19, 2023
@sunithasomanna sunithasomanna self-assigned this Jan 19, 2023
ashraf-vazeer
ashraf-vazeer approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ashraf-vazeer ashraf-vazeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashraf-vazeer ashraf-vazeer merged commit 3939462 into ODIM-Project:development Jan 20, 2023
@ashraf-vazeer ashraf-vazeer deleted the odim-6963 branch January 20, 2023 03:26
@sunithasomanna sunithasomanna added status:resolved issue is completed and confirmed to be working as expected and removed status:in-progress issue has been accepted previously and now taken up for implementation labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amar-shalgar amar-shalgar amar-shalgar approved these changes

@ashraf-vazeer ashraf-vazeer ashraf-vazeer approved these changes

Assignees

@sunithasomanna sunithasomanna

Labels
prio:normal normal priority, can be taken up after high priority issues are addressed status:resolved issue is completed and confirmed to be working as expected type:doc This tag is for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunithasomanna @ashraf-vazeer @amar-shalgar