Handle COMMON keyword in PROGRAM-ID
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nberth
reviewed
Mar 20, 2024
| @@ -46,17 +46,26 @@ and program_level = | |||
| } | |||
| | ProgramPrototype | |||
|
|
|||
| and program_mode = { prog_is_common : bool; | |||
There was a problem hiding this comment.
Could you reformat as the other records ({ and } alone on their lines), and more importantly, put the comment "only within a nested program" on the right of prog_is_common?
| let pp_program_mode ppf { prog_is_common; | ||
| prog_kind } = | ||
| match prog_kind with | ||
| | None when prog_is_common -> Fmt.pf ppf "COMMON" |
There was a problem hiding this comment.
Please break lines after each ->.
nberth
changed the title
COMMON keyword in PROGRAM-ID
Fix coding style
engboris
force-pushed
the
engboris-add-progid-common
branch
from
fc0ac24
to
11f5e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The grammar could recognise the
INITIAL,RECURSIVEandCOMMONkeywords afterPROGRAM-ID. id IS?but not:INITIAL COMMONandRECURSIVE COMMON;COMMON INITIALandCOMMON RECURSIVEI followed the grammar of GnuCOBOL.