Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support bytecode-only environments #1175

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

bclement-ocp
Copy link
Collaborator

We use dune-site for the inequalities plugin, but not for the AB Why3 plugin. Since this plugin is deprecated, simply mark it as incompatible with bytecode-only environments.

Fixes #1066

We use dune-site for the inequalities plugin, but not for the AB Why3
plugin. Since this plugin is deprecated, simply mark it as incompatible
with bytecode-only environments.

Fixes OCamlPro#1066
@Halbaroth
Copy link
Collaborator

It is incompatible with bytecode compilation because Dynlink cannot work in bytecode?

@bclement-ocp
Copy link
Collaborator Author

No, it is incompatible with bytecode compilation because the install rule lists the .cmxs file which is only produced by native compilers. I am sure we could find a way to conditionally list this file, but I didn't find such a way from a quick look at the dune doc. Given that the plugin is deprecated anyways, I don't think it is worth spending time on it — especially since this is to please the OPAM CI only, the alt-ergo-plugin-ab-why3 package already does not build in bytecode-only environments.

@bclement-ocp bclement-ocp merged commit 521742d into OCamlPro:next Jul 23, 2024
14 checks passed
@bclement-ocp bclement-ocp deleted the fix-1066 branch July 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that we are compatible with bytecode-only environments
2 participants