Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Use OCaml 4.14.2 for Makefile tests #1074

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

bclement-ocp
Copy link
Collaborator

No description provided.

@Halbaroth
Copy link
Collaborator

I hesitated to bump the minimal OCaml version as you did. The only reason for which we need OCaml >= 4.14 is because the latest version of js_zarith_stubs as such a requirement but this package isn't a dependency of Alt-Ergo itself. I believe no ones use the AE js worker but us.

@bclement-ocp
Copy link
Collaborator Author

This does not bump the minimal OCaml version, it only changes the version that is only used on the CI to test the "Make all" target. Version constraints are unchanged, and we are still otherwise testing OCaml 4.08 / 4.14 / 5.0.

@Halbaroth
Copy link
Collaborator

By bumping the minimal version, I meant bumping the minimal version tested by the CI.
If we still test OCaml 4.08 on the CI for the binary and the library, I agree ;)

@Halbaroth Halbaroth merged commit d0da55f into OCamlPro:next Mar 25, 2024
13 checks passed
@bclement-ocp
Copy link
Collaborator Author

Yes — the change only concerns the "Make all" workflow (which simply checks that we can build using make); it does not apply to the other workflows (those that actually run the tests) as they use a different matrix!

Halbaroth pushed a commit to Halbaroth/alt-ergo that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants