more intuitive ID for output file, #26 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutely, yes. The alternative is to not change the ID at all and accept that it gets slightly long, e.g. |
|
or maybe even better: ID = concat_padded(self.output_file_grp, os.path.basename(input_file.url)[:-4])why generate ids if output_file_grp + basename of file without extension is unique? |
|
I am very much in favour of the solution by @finkf, but I would also like to keep the |
|
Closing as this is superseded (and hopefully resolved to satisfaction) by #48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the output ID and filename from the input file ID reduced to its numbers.
@finkf