segment-region: only ignore if candidate outside Border #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
force-pushed
the
segment-clip-border
branch
from
db34260 to
94dce57
Compare
bertsky
force-pushed
the
segment-clip-border
branch
from
94dce57 to
4818e72
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 37.77% 37.64% -0.13%
==========================================
Files 9 9
Lines 998 1004 +6
Branches 212 214 +2
==========================================
+ Hits 377 378 +1
- Misses 555 558 +3
- Partials 66 68 +2
Continue to review full report at Codecov.
|
|
@kba if you want, I can export the last 3 commits as extra PR. |
kba
reviewed
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #139