Skip to content

Commit

Permalink
Dockerfile: move ARGs below FROM
Browse files Browse the repository at this point in the history
  • Loading branch information
@bertsky
bertsky authored Apr 27, 2022
1 parent 631e718 commit 5a978b5
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,19 @@
# docker-compose / kubernetes
# cons:
# - needs submodules checked out at build time,
# which implies a huge (1.5GB) build context
# which implies a huge build context
# - needs to pull in all possible dependencies,
# which implies a huge (6.7GB) final image
# which implies a huge final image
# - danger of running into inconsistent dependencies
# between modules (just as ocrd_all for local installation)

ARG VCS_REF
ARG BUILD_DATE
ARG BASE_IMAGE

# use OCR-D base container (from ubuntu:18.04)
ARG BASE_IMAGE ocrd/core
FROM $BASE_IMAGE
ARG VCS_REF
ARG BUILD_DATE
LABEL \
maintainer="https://ocr-d.de/kontakt" \
maintainer="https://ocr-d.de/en/contact" \
org.label-schema.vcs-ref=$VCS_REF \
org.label-schema.vcs-url="https://github.com/OCR-D/ocrd_all" \
org.label-schema.build-date=$BUILD_DATE
Expand Down

1 comment on commit 5a978b5

@bertsky
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry @kba @stweil! I thought I'd create a PR instead of changing master – must have slipped through.

Rationale: Our specifications require LABEL tagging, which has not worked for at least 2 years now.

Reason is explained in moby/moby#34129

Please sign in to comment.