[wip] Sort children of OrderedGroup etc. by @index #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
requested changes
May 12, 2020
Co-authored-by: Robert Sachunsky <[email protected]>
Co-authored-by: Robert Sachunsky <[email protected]>
Co-authored-by: Robert Sachunsky <[email protected]>
* `get_AllIndexed()`: list all RegionRefIndexed, OrderedGroupIdexed and UnorderedGroupIndexed elements, sorted ascending by their index * `clear_Allindexed()`: Removes all RegionRefIndexed, OrderedGroupIdexed and UnorderedGroupIndexed elements and reeutrns them * `add_AllIndexed(elmenets): Add a variety of RegionRefIndexed, OrderedGroupIdexed and UnorderedGroupIndexed elmenets with proper sort byt index On export of an OrderedGroup, the elements are listed with `get_AllIndexed` and hence should have the correct order. Also when exporting: all empty OrderedGroupIdexed/UnorderedGroupIndexed will be replaced with `RegionRefIndexed` with appropriate `index` nd `regionRef`
bertsky
approved these changes
May 13, 2020
|
Alas, the new export functionality only arrived at |
|
Obviously an error in the regex for class_names, fixing. |
|
Cannot reproduce the issue, I see defintion for and Not sure what I can do. Can you provide a small code sample to test? |
|
You are right. Don't know just what I saw. Everything seems to be working fine. Sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides the
exportChildrenof the generatedOrderedGroupTypeand sorts the containedRegionRefIndexed(andOrderedGroupIndexedandUnorderedGroupIndexed) by their resp.@index` attribute.While this works as expected, the output still is unsorted and I am temporarily stumped as to why.
While I'm confidant that it should not involve much more code, I currently cannot see what the issue ist. Will try again tomorrow but if someone has an idea, I am happy hearing them.