Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have save_mets use UTF-8 encoding for byte-serialization… #388

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Jan 4, 2020

…to avoid HTML-encoding non-ASCII codepoints.

Fixes #326

@bertsky bertsky requested a review from kba January 4, 2020 00:27
@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files          31       31           
  Lines        1856     1856           
  Branches      356      356           
=======================================
  Hits         1576     1576           
  Misses        222      222           
  Partials       58       58
Impacted Files Coverage Δ
ocrd_models/ocrd_models/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd3232...886cc29. Read the comment docs.

@kba kba merged commit 2cd7a4b into OCR-D:master Jan 6, 2020
@bertsky bertsky deleted the fix-save-mets branch October 8, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_xml with xmllint=True should also use encoding UTF-8
3 participants