Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent for processors on save #191

Merged
merged 6 commits into from
Oct 23, 2018
Merged

Add agent for processors on save #191

merged 6 commits into from
Oct 23, 2018

Conversation

kba
Copy link
Member

@kba kba commented Oct 19, 2018

c.f. #147

@kba kba closed this Oct 22, 2018
@kba kba changed the title WIP: Add agent for processors on save Add agent for processors on save Oct 22, 2018
@kba kba reopened this Oct 22, 2018
@kba kba closed this Oct 22, 2018
@kba kba reopened this Oct 22, 2018
@OCR-D OCR-D deleted a comment from codecov-io Oct 22, 2018
kba added a commit to kba/spec that referenced this pull request Oct 22, 2018
@kba
mets: agents for recording provenance in human-readable way, fix OCR-…
74a2459 
…D#79,

OCR-D/core#147
OCR-D/core#191
@kba kba mentioned this pull request Oct 22, 2018
Merged
@codecov-io
Copy link

codecov-io commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #191 into master will increase coverage by 3.93%.
The diff coverage is 95.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   48.09%   52.03%   +3.93%     
==========================================
  Files          27       28       +1     
  Lines         973     1034      +61     
  Branches      158      169      +11     
==========================================
+ Hits          468      538      +70     
+ Misses        464      453      -11     
- Partials       41       43       +2
Impacted Files Coverage Δ
ocrd/model/ocrd_page.py 62.5% <0%> (ø) ⬆️
ocrd/resolver.py 35.04% <100%> (ø) ⬆️
ocrd/processor/base.py 64.61% <100%> (+16.28%) ⬆️
ocrd/constants.py 100% <100%> (ø) ⬆️
ocrd/model/ocrd_mets.py 91.25% <100%> (+0.83%) ⬆️
ocrd/model/ocrd_agent.py 97.87% <97.87%> (ø)
ocrd/model/ocrd_xml_base.py 83.33% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582f52b...72ea857. Read the comment docs.

VolkerHartmann
VolkerHartmann approved these changes Oct 23, 2018
View reviewed changes
Copy link

@VolkerHartmann VolkerHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review. It seems to be OK.

@kba kba merged commit 8b1d38b into OCR-D:master Oct 23, 2018
@kba kba deleted the agent-on-save branch October 23, 2018 10:17
@kba kba mentioned this pull request Oct 30, 2018
Closed
bertsky pushed a commit to bertsky/core that referenced this pull request Apr 26, 2023
@stweil
Merge pull request OCR-D#191 from stweil/master
9cd7f8d 
Update submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VolkerHartmann VolkerHartmann VolkerHartmann approved these changes

@wrznr wrznr Awaiting requested review from wrznr

@tboenig tboenig Awaiting requested review from tboenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kba @codecov-io @VolkerHartmann