resolver: when downloading a file-url fall back to url for basename, … #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cneud
approved these changes
Aug 21, 2018
ocrd/resolver.py
Outdated
| @@ -119,6 +119,8 @@ def download_to_directory(self, directory, url, basename=None, overwrite=False, | |||
| """ | |||
| Download a file to the workspace. | |||
|
|
|||
| Early Shortcut: If iit's a file-URL and already in the directory, keep it there. | |||
bertsky
pushed a commit
to bertsky/core
that referenced
this pull request
Apr 26, 2023
…ssue OCR-D#165) Signed-off-by: Stefan Weil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading, to a known directory, a
file://URL referencing a path within that directory, the resolver assumed the URL to be opaque and created a safe filename version of that URL. Which adds up to exponentially long filenames when repeated.This PR catches that case (basename not set, file-URL pointing to the workspace directory) and should result in a no-op if that file already exists.