Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resource Manager: Unlink archives after extracting #1245 #1246

Merged
merged 14 commits into from
Jul 11, 2024
Merged

Conversation

MehmedGIT
Copy link
Contributor

@MehmedGIT MehmedGIT commented Jul 3, 2024

A fix for #1245 and some minor refactoring related to strings.

@MehmedGIT MehmedGIT changed the title Fix 1245 Fix for issue 1245 Jul 3, 2024
@MehmedGIT MehmedGIT changed the title Fix for issue 1245 fix: Resource Manager: Unlink archives after extracting #1245 Jul 4, 2024
@MehmedGIT MehmedGIT requested review from kba and bertsky July 4, 2024 10:37
@MehmedGIT
Copy link
Contributor Author

MehmedGIT commented Jul 4, 2024

To not make this PR just some refactoring, I would tackle #1201 here as well. Once that is resolved I have an additional idea. Skipping existing resources should also be an option.

Currently

ocrd resmgr download '*'

fails if there are some existing models. The -o flag is a must in that case. However, that is not optimal. Ideally, skipping existing resources should also be possible. The -o and -s flags will be mutually exclusive.

-s, --skip    Skip existing resources

Then

ocrd resmgr download -s '*'

Will download the missing resources only. That is also useful when a connection error occurs and the model downloading should be restarted.

@bertsky, does that make sense?

@bertsky
Copy link
Collaborator

bertsky commented Jul 4, 2024

I would tackle #1201 here as well.

great!

Currently

ocrd resmgr download '*'

fails if there are some existing models. The -o flag is a must in that case. However, that is not optimal. Ideally, skipping existing resources should also be possible. The -o and -s flags will be mutually exclusive.

Ouch! I did not notice this before. Very good point!

But then I would rather recommend making -s the implicit/default, and -o the non-default behaviour.

@MehmedGIT
Copy link
Contributor Author

But then I would rather recommend making -s the implicit/default

d5173ad.

@kba kba merged commit 8ea5857 into master Jul 11, 2024
21 checks passed
kba added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants