-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resource Manager: Unlink archives after extracting #1245 #1246
Conversation
To not make this PR just some refactoring, I would tackle #1201 here as well. Once that is resolved I have an additional idea. Skipping existing resources should also be an option. Currently
fails if there are some existing models. The
Then
Will download the missing resources only. That is also useful when a connection error occurs and the model downloading should be restarted. @bertsky, does that make sense? |
great!
Ouch! I did not notice this before. Very good point! But then I would rather recommend making |
|
A fix for #1245 and some minor refactoring related to strings.