-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional parameter for custom resolution #376
Comments
I see the need, too. But we already rely on core's |
Yes, but it's not trivial I'm afraid. My idea would be to allow overriding the pixel density values in the OcrdExif constructor but that gets called in workspace methods and model factory function. These would need to accept additional parameters to pass on to the OcrdExif constructor. Not complicated, just a bit convoluted, e.g. even more parameters to I do see the need though, so if the added complexity is fine by you, I'll create a PR in core. |
But that only gets called by the processor again, so we are still where we started (adding a parameter for every single tool)! Perhaps we should start adding other mechanisms that affect all processors equally (like the loglevel override):
Besides the manual DPI override, this would also allow supporting DPI meta-data validation with different levels of strictness. Or supporting automatic workspace validation with different levels/sets of checks. Or supporting processing with Or supporting processing on multiple CPUs/GPUs with given scalefactor. Or supporting time constraints on different hierarchy levels. Just saying! |
Anyway, IMO this issue should be transferred to core or spec, since it involves/affects more people/projects. |
At least for the DPI override, another processor-independent mechanism could be to have a dedicated processor earlier in the pipeline writing @kba can you please transfer the issue? |
Or enabling/disabling METS caching (or even METS server). |
Hello,
please add DPI-Parameters to enable to enforce custom resolution when using tesseract
Tesseract CLI
--dpi 470
ocrd-tesserocr
dpi: 470
The text was updated successfully, but these errors were encountered: