Fix some issues with virt bundle #615
Open
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computate
approved these changes
Nov 27, 2024
- We are installing a subscription for the `kubevirt-hyperconverged` operator, but the subscription was named `hco-operatorhub`. - The operatorgroup had an unnecessary `-group` suffix, which doesn't match our other installs. - The bundle included resources which, according to cbea925, it's not clear if we need or not. Move this into the test cluster overlay for now in line with the comment in that commit.
|
@computate Because we're renaming a subscription here, this may require manual intervention on the test cluster when it merges. I will ping you before that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are installing a subscription for the
kubevirt-hyperconvergedoperator, but the subscription was named
hco-operatorhub.The operatorgroup had an unnecessary
-groupsuffix, which doesn't matchour other installs.
The bundle included resources which, according to cbea925, it's not
clear if we need or not. Move this into the test cluster overlay for now
in line with the comment in that commit.