Added certs and key for grafana #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwesig
added
enhancement
|
Nice @jbasu01 , we should test this out on Monday, and remove the comments in the code. |
|
Sounds good @computate . By the way, it was a joint effort between Thor and myself. |
|
comment from Lars |
jbasu01
force-pushed
the
20240112_grafanaobs
branch
3 times, most recently
from
2618232 to
f0b885f
Compare
Signed-off-by: Jeet Basu <[email protected]> Corrected the secrets variables
jbasu01
force-pushed
the
20240112_grafanaobs
branch
from
f0b885f to
20d64cc
Compare
computate
approved these changes
Jan 23, 2024
|
@jbasu01 looks good! If you believe this is ready to merge, please remove the "WIP" in the title. |
jbasu01
changed the title
|
Excellent work @jbasu01 @schwesig @harshil-codes , I see the grafana metrics working with the new observatorium data source applied! |
|
Thanks, Yes, we just checked it after the merge 👍🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@computate please review