Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] website_url_sitemap_exclusion #957

Closed
wants to merge 1 commit into from
Closed

[ADD] website_url_sitemap_exclusion #957

wants to merge 1 commit into from

Conversation

SirTakobi
Copy link

No description provided.

@SirTakobi
Copy link
Author

CI should be fixed after #958

@SirTakobi SirTakobi marked this pull request as ready for review February 27, 2023 13:34
@SirTakobi SirTakobi force-pushed the 12.0-add-website_url_sitemap_exclusion branch 2 times, most recently from 55920c8 to 301736f Compare March 20, 2023 09:30
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
@SirTakobi SirTakobi force-pushed the 12.0-add-website_url_sitemap_exclusion branch from 301736f to 0cd5b87 Compare July 24, 2023 07:38
eLBati
eLBati approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

simahawk
simahawk reviewed Jul 26, 2023
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking remarks

website_url_sitemap_exclusion/models/website_forbidden_url.py


class WebsiteForbiddenUrls(models.Model):
_name = "website.forbidden.url"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe matter of taste but I would use "blacklist(ed)" instead of "forbidden".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had thought of it from the beginning :)
Since this would require a migration and some renaming throughout the whole module, I'd rather leave it as is

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe good for the roadmap? 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 added to the roadmap

@SirTakobi SirTakobi force-pushed the 12.0-add-website_url_sitemap_exclusion branch from 0cd5b87 to ad5783c Compare July 26, 2023 07:49
@SirTakobi SirTakobi marked this pull request as draft July 26, 2023 07:50
@SirTakobi SirTakobi marked this pull request as ready for review July 26, 2023 07:52
SirTakobi
SirTakobi commented Jul 26, 2023
View reviewed changes
Copy link
Author

@SirTakobi SirTakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

website_url_sitemap_exclusion/models/website_forbidden_url.py


class WebsiteForbiddenUrls(models.Model):
_name = "website.forbidden.url"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had thought of it from the beginning :)
Since this would require a migration and some renaming throughout the whole module, I'd rather leave it as is

@SirTakobi SirTakobi requested a review from simahawk July 26, 2023 07:54
@SirTakobi SirTakobi force-pushed the 12.0-add-website_url_sitemap_exclusion branch from ad5783c to 4d86048 Compare July 26, 2023 07:58
@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 26, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SirTakobi SirTakobi marked this pull request as draft July 26, 2023 09:05
@SirTakobi SirTakobi force-pushed the 12.0-add-website_url_sitemap_exclusion branch from 4d86048 to 7ad97aa Compare July 26, 2023 09:08
@SirTakobi SirTakobi marked this pull request as ready for review July 26, 2023 09:09
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024
@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenCode OpenCode OpenCode approved these changes

@simahawk simahawk simahawk approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SirTakobi @OCA-git-bot @OpenCode @simahawk @eLBati