[14.0][FIX][IMP] web_ir_actions_act_multi: uninstall issue #2817
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes uninstallation issue of web_ir_actions_act_multi module. At the time uninstallation, it removes several columns like name, binding_model_id, binding_type, binding_view_types... from ir_actions, ir_act_server, etc. This makes the database not usable anymore.
OpenCode
approved these changes
May 7, 2024
gaikaz
reviewed
Jun 28, 2024
|
it doesn't break the intended functionality |
gaikaz
approved these changes
Jul 1, 2024
baguenth
approved these changes
Sep 26, 2024
|
@matiasperalta1 Can you may also take a look? This was initially added by you. Maybe you can also remember why adding _table in the first place? In general I am confused why we need the .py-part at all. |
chienandalu
reviewed
Sep 27, 2024
| _table = "ir_actions" | ||
| _table = "ir_act_multi" |
There was a problem hiding this comment.
I think you should better do this with an uninstall hook to avoid having another relation. And maybe this could have migration issues when updating the module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes uninstallation issue of web_ir_actions_act_multi module. At the time of uninstallation, it removes several columns like name, binding_model_id, binding_type, binding_view_types... from ir_actions, ir_act_server, etc. This makes the database not usable anymore.
Fixes #2394