[14.0][ADD] hr_timesheet_predefined_description: Add predefined descriptions for timesheets #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-lopez-tecnativa
suggested changes
Sep 4, 2024
hr_timesheet_predefined_description/tests/test_account_analytic_line.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/tests/test_account_analytic_line.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/tests/test_account_analytic_line.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/tests/test_hr_timesheet_predefined_description.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/views/hr_timesheet_views.xml
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/models/hr_timesheet_predefined_description.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/models/hr_timesheet_predefined_description.py
Outdated
Show resolved
Hide resolved
juanjosesegui-tecnativa
force-pushed
the
14.0-add-hr_timesheet_predefined_description
branch
3 times, most recently
from
a38e0e2 to
c8e3658
Compare
victoralmau
suggested changes
Sep 5, 2024
hr_timesheet_predefined_description/security/ir.model.access.csv
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/views/hr_timesheet_views.xml
Outdated
Show resolved
Hide resolved
juanjosesegui-tecnativa
force-pushed
the
14.0-add-hr_timesheet_predefined_description
branch
2 times, most recently
from
441ac85 to
a2788ca
Compare
pedrobaeza
requested changes
Sep 11, 2024
hr_timesheet_predefined_description/models/account_analytic_line.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/models/account_analytic_line.py
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/data/hr_timesheet_predefined_description_data.xml
Outdated
Show resolved
Hide resolved
hr_timesheet_predefined_description/tests/test_hr_timesheet_predefined_description.py
Outdated
Show resolved
Hide resolved
| <field name="model">timesheet.predefined.description</field> | ||
| <field name="arch" type="xml"> | ||
| <tree string="Predefined Descriptions" editable="bottom"> | ||
| <field name="name" /> |
There was a problem hiding this comment.
Missing company_id field, and also missing record rules for multi-company.
| <field name="model">account.analytic.line</field> | ||
| <field name="inherit_id" ref="hr_timesheet.hr_timesheet_line_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="name" position="attributes"> |
There was a problem hiding this comment.
Don't hide the name field. Make it readonly (with force_save="1") if the predefined description is set.
| <field name="name" position="attributes"> | ||
| <attribute name="invisible">1</attribute> | ||
| </field> | ||
| <field name="name" position="after"> |
There was a problem hiding this comment.
Suggested change
| <field name="name" position="after"> | |
| <field name="name" position="before"> |
| </field> | ||
| </field> | ||
| </record> | ||
| <record id="view_project_task_form_inherit" model="ir.ui.view"> |
There was a problem hiding this comment.
The same as above for this view.
juanjosesegui-tecnativa
force-pushed
the
14.0-add-hr_timesheet_predefined_description
branch
2 times, most recently
from
b1b14d1 to
5d028ed
Compare
|
I have implemented all the requested changes and adjusted the tests so that they pass without any errors. If you notice any further modifications are needed, feel free to let me know. |
pedrobaeza
force-pushed
the
14.0-add-hr_timesheet_predefined_description
branch
3 times, most recently
from
d470048 to
353795a
Compare
…s for timesheets TT50619 Co-Authored-By: Pedro M. Baeza <[email protected]>
pedrobaeza
force-pushed
the
14.0-add-hr_timesheet_predefined_description
branch
from
353795a to
3715956
Compare
pedrobaeza
approved these changes
Sep 18, 2024
victoralmau
approved these changes
Sep 18, 2024
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at bf2fa48. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT50619