Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] hr_timesheet_sheet migration to 17.0 #703

Open
wants to merge 225 commits into
base: 17.0
Choose a base branch
from
Open

[MIG] hr_timesheet_sheet migration to 17.0 #703

wants to merge 225 commits into from

Conversation

vnikolayev1
Copy link

@vnikolayev1 vnikolayev1 commented Aug 14, 2024 •
edited
Loading

  • ported module from version 16 to version 17
  • fixed/updated tests, logic based on views change
  • updated pre-commit auto fixes

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@vnikolayev1 vnikolayev1 force-pushed the 17.0 branch 2 times, most recently from 42e3a36 to b26edde Compare August 14, 2024 18:09
MiquelRForgeFlow and others added 27 commits August 15, 2024 18:19
@MiquelRForgeFlow
[11.0][MIG] hr_timesheet_sheet (OCA#125)
c2f422d 
* [10.0] hr_timesheet_sheet

* [11.0][MIG] hr_timesheet_sheet

* [REMOVE] hr_timesheet.sheet.account

* [REMOVE] 'new' state

* [ADD] Tests

* [UPD] Adapt to multicompany

* [ADD] Add more tests (include multicompany tests)

* [FIX] project_task_stage_allow_timesheet: show error message only if task

* [ADD] Migration scripts to v11
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
c90aa2c
@yostashiro
Translated using Weblate (Japanese)
30fba78 
Currently translated at 98.9% (88 of 89 strings)

Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/
Translated using Weblate (Português (Brasil))
9618cde 
Currently translated at 100,0% (89 of 89 strings)

Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/pt_BR/
@JordiBForgeFlow
[11.0][hr_timesheet_sheet]: allow to display more than 40 cells
c14c0cc
@JordiBForgeFlow
hr_timesheet_sheet: add menu 'Timesheet Sheets to Approve'
c13765f
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
3ce8f3d
@JordiBForgeFlow
hr_timesheet_sheet: pass selected project context to task creation
ff05f2f
@astirpe
[11.0][IMP] hr_timesheet_sheet: ease extensions (OCA#131)
5dc5619
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
0b5f525
@astirpe
Fix task domain and default project_id
0f7594e
@astirpe
Bump version
decc5a4
@astirpe
[IMP] hr_timesheet_sheet ux
2a17f6f
@astirpe
Code review
ceb26ba
@astirpe
Update contributors list
d8cc4c5
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
536a80d
@astirpe
[FIX] hr_timesheet_sheet: "Refuse" button name (OCA#134)
e3adaa1
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
5caf646
@LoisRForgeFlow
[11.0][IMP] hr_timesheet_sheet: merge hr_timesheet_sheet_week_start_d…
32ac249 
…ay into this module, which adds a configuration to select the week start day.
@oca-travis
[UPD] Update hr_timesheet_sheet.pot
600ea65
@JordiBForgeFlow
restrict selection of projects to those that have 'allow_timsheets' set
de1163e
@alexey-pelykh
[MIG] hr_timesheet_sheet: Migration to 12.0
a032c99
@oca-transbot
Update translation files
6e3507a 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@pedrobaeza
[FIX] hr_timesheet_sheet: Don't fail tests on Sunday
ddfa2f2 
If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday,
which belongs to other week, and thus not included in same timesheet. With this,
we cover that case, decreasing one day instead of adding it.
@alexey-pelykh
[IMP] hr_timesheet_sheet: more extendability & cleanup
72babde
@AdriaGForgeFlow
[FIX] Fix related fields in hr_timesheet_sheet
d312aee
@MiquelRForgeFlow
[FIX] hr_timesheet_sheet: who approves timesheets should be the manager
94d7197
adrianojprado and others added 20 commits August 15, 2024 18:19
@adrianojprado
Translated using Weblate (Portuguese (Brazil))
ca4154f 
Currently translated at 100.0% (182 of 182 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/pt_BR/
@remi-filament
Translated using Weblate (French)
20ac6a7 
Currently translated at 95.0% (173 of 182 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/fr/
[UPD] Update hr_timesheet_sheet.pot
97158a8
@weblate
Update translation files
476dab4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/
@pere-aquarian
Translated using Weblate (Catalan)
2009d69 
Currently translated at 100.0% (181 of 181 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/ca/
@mymage
Translated using Weblate (Italian)
8de13f9 
Currently translated at 100.0% (181 of 181 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/it/
@mymage
Translated using Weblate (Italian)
10c084f 
Currently translated at 100.0% (181 of 181 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/it/
@jakobkrabbe
Translated using Weblate (Swedish)
c2bfb0c 
Currently translated at 99.4% (180 of 181 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/sv/
@LauraCForgeFlow
[16.0][FIX] hr_timesheet_sheet: permissions on access to menus
f3506ee
@LauraCForgeFlow
[16.0][FIX] hr_timesheet_sheet: update translations (Spanish)
2c11ef1
[UPD] Update hr_timesheet_sheet.pot
5ace510
@weblate
Update translation files
48afe95 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/
@OCA-git-bot
[BOT] post-merge updates
7b51578
@weblate
Update translation files
f0b4d42 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/
@mymage
Translated using Weblate (Italian)
2e51152 
Currently translated at 100.0% (183 of 183 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/it/
@pedrocs-exo
Translated using Weblate (Portuguese)
5b1ab4b 
Currently translated at 82.5% (151 of 183 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/pt/
@pedrocs-exo
Translated using Weblate (Portuguese)
3019907 
Currently translated at 84.1% (154 of 183 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/pt/
Translated using Weblate (Portuguese (Brazil))
647bff7 
Currently translated at 100.0% (183 of 183 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_sheet
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_sheet/pt_BR/
[IMP] hr_timesheet_sheet: pre-commit auto fixes
2e25da3
[MIG] hr_timesheet_sheet migration to 17.0
d681e67 
- ported module from version 16 to version 17
- fixed/updated tests, python logic based on views changes
- fixed linter errors
@vnikolayev1
Copy link
Author

@pedrobaeza Thank you for migration guide, here is an update.

@pedrobaeza
Copy link
Member

/ocabot migration hr_timesheet_sheet

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 15, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#617) has not been updated to reference the current pull request because a previous pull request (#687) is not closed.
Perhaps you should check that there is no duplicate work.
CC @SodexisTeam

@pedrobaeza
Copy link
Member

@vnikolayev1 it seems there's another migration on progress. Did you check it?

@vnikolayev1
Copy link
Author

vnikolayev1 commented Aug 16, 2024 •
edited
Loading

@pedrobaeza probably i should check if it exists first.

Looks like it has some extra functionality here ( _check_can_write method) e952741
settings views are not updated,
tests does not look like were touched either (they should be updated because we change readonly logic)

Sadly they did same mistake like i did on my first push - did not use patch so it' s hard to see everything what is changed

Looks like i did a bit better porting overall, so maybe their extra changes can be placed over mine later

p.s. is there anything i could read on how to check existing MR and what to do with them(or what should i google)? i am relatively new to this.

@pedrobaeza
Copy link
Member

Please review and put comments in the other PR.

@vnikolayev1 vnikolayev1 mentioned this pull request Aug 16, 2024
Merged
@pedrobaeza
Copy link
Member

Please include #712 if this PR is finally used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.