Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_timesheet_line_exclude #639

Merged
merged 17 commits into from
Mar 18, 2024
Merged

[17.0][MIG] sale_timesheet_line_exclude #639

merged 17 commits into from
Mar 18, 2024

Conversation

MohamedOsman7
Copy link

No description provided.

@MohamedOsman7 MohamedOsman7 marked this pull request as ready for review February 23, 2024 13:07
@MohamedOsman7 MohamedOsman7 mentioned this pull request Feb 23, 2024
Open
14 tasks
@MohamedOsman7 MohamedOsman7 marked this pull request as draft February 23, 2024 13:09
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_timesheet_line_exclude branch from 5b39660 to 6d50cf2 Compare February 23, 2024 14:02
@MohamedOsman7 MohamedOsman7 marked this pull request as ready for review February 23, 2024 14:20
alexey-pelykh and others added 16 commits February 27, 2024 13:42
@alexey-pelykh
[ADD] sale_timesheet_line_exclude: exclude Timesheet Line from Sale O…
416f628 
…rder
@alexey-pelykh
[12.0][FIX] Manifest fixes (OCA#255)
c432f84 
* [FIX] sale_timesheet_line_exclude: fix manifest
* [FIX] sale_timesheet_task_exclude: fix manifest
@marylla
Added translation using Weblate (German)
c8c5773
@josepmy
Added translation using Weblate (Spanish)
533d39b
@alexey-pelykh
[UPD] Brainbean Apps => CorporateHub
f63050c
@dreispt
[FIX] sale_timesheet_line_exclude: user friendly Non-billable label
cd68b93
@ypapouin
Added translation using Weblate (French)
2090b2d
@Du-ma
[IMP] sale_timesheet_line_exclude: black, isort, prettier
fd696da
@Du-ma
[MIG] sale_timesheet_line_exclude: migration to 13.0
2694584
@dantiller2
[MIG] sale_timesheet_line_exclude: Migration to 14.0
2b8f7e5
@Freni-OSI
[15.0][MIG] sale_timesheet_line_exclude
2cef6f7
@vincent-hatakeyama
Translated using Weblate (French)
52283ed 
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-15.0/timesheet-15.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-sale_timesheet_line_exclude/fr/
@mymage
Added translation using Weblate (Italian)
91ba1e0
[MIG] sale_timesheet_line_exclude: Migration to 16.0
15a55a6
@adrianojprado
Added translation using Weblate (Portuguese (Brazil))
218a994
[IMP] sale_timesheet_line_exclude: black, isort, prettier
78dccea
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_timesheet_line_exclude branch 2 times, most recently from 6c1b0b9 to 5f91f96 Compare February 27, 2024 13:45
CRogos
CRogos suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and Code Review LGTM, but the .deb file needs to be removed.

pandoc-3.1.12.1-1-amd64.deb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_timesheet_line_exclude branch from 5f91f96 to 7f2a040 Compare February 28, 2024 09:29
alexey-pelykh
alexey-pelykh approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor

CRogos commented Mar 18, 2024

@alexey-pelykh can you also merge this?

@alexey-pelykh
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-639-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7f7232f into OCA:17.0 Mar 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9af94c0. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-mig-sale_timesheet_line_exclude branch March 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.