[18.0][FIX] fs_storage: fix _ls_check_connection when dealing with huge amount of files in root folder
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
commented
Mar 4, 2025
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| _logger = logging.getLogger(__name__) | |||
|
|
|||
| LS_NON_EXISTING_FILE = ".NON_EXISTING_FILE" | |||
There was a problem hiding this comment.
Should it be a new config field? Should we add some random characters when using it to ensure it is non-existing on remote FS?
There was a problem hiding this comment.
(even if the file exists, as soon as ls returns we are good)
sebalix
force-pushed
the
18-fix-fs_storage
branch
from
0972547 to
d510be3
Compare
sebalix
force-pushed
the
18-fix-fs_storage
branch
from
d510be3 to
84a4755
Compare
henrybackman
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We tried to configure a storage on an
AzureBlobFileSystemwith 3.8+M of files located at the root directory.Issue
This storage is in read-only access, so we have to use the other option
lsto check the connection. Issue is that the currentlson root folder will try to return too much file names, increasing the consumed memory, leading to a kill of the Odoo process.Proposed solution
Perform this
lson a non-existing file, which should then raiseFileNotFoundError(to check if this exception is returned by all protocols?). If nothing is raised, that also means the connection is working (as before).