[18.0][MIG] storage_backend_s3: Migration to 18.0 #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the way to build the url (use a generic base_url). - make more generic the storage backend by moving specific feature in storage file - better name for variable "name" in store and retrieve method use "relative_path" instead - extra amazon S3 storage component in a separated module with test using vcrpy
…t with the specifiation of the type of file binary or base64
* support custom endpoint * refactor bucket handling * re-register vcrpy tests
Long time due ;)
ivantodorovich
approved these changes
Jan 6, 2025
thienvh332
force-pushed
the
18.0-mig-storage_backend_s3
branch
from
e5b35e5 to
807b816
Compare
thienvh332
force-pushed
the
18.0-mig-storage_backend_s3
branch
from
807b816 to
c0e71cb
Compare
|
/ocabot migration storage_backend_s3 |
lmignon
approved these changes
Jan 30, 2025
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Jan 30, 2025
|
@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-440-by-lmignon-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.