Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] stock_auto_move: Allow to do a chained move automatically and transfer partial picking (with BO) #737

Closed
wants to merge 3 commits into from
Closed

[10.0][IMP] stock_auto_move: Allow to do a chained move automatically and transfer partial picking (with BO) #737

wants to merge 3 commits into from

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Nov 18, 2020 •
edited
Loading

@zakiuu @rousseldenis
[IMP]stock_auto_move: auto move from push rules
3085781
@zakiuu @rousseldenis
[9.0][REF]stock_auto_move: fix action_assign() (OCA#373)
cb8e3a1 
* The `_apply` method should not be overridden. In case of three step
operation with the last step set to auto move. The override of the
`_apply` method was causing the second move to be automatic as well.

**Use case**: doing a reception operation in two steps where the moves on
the second step are set to be automatic (using the push rule in this
case), and the reception is done partially.
**Expected Result**: When doing a first reception step partially a back
order is created, and we expect the second step to have a back order for
the remaining qty as well.
**Current behavior**: The correct move is processed automatically but no
backorder is created. The reason for that behavior is we processing the
move directly (i.e calling `action_done` of the `stock.move`) without
going through the normal process (i.e processing the second step
picking).
**The solution to the problem**: The processing the of the automatic
stock move should follow the same behavior as done from the user interface.
I've added a new function in `stock.picking` model called
`_transfer_pickings_with_auto_move` to simulate the same behavior this
function is called inside the `action_assign` of the stock move instead
of calling the `action_done` of the move.
@rousseldenis rousseldenis added this to the 10.0 milestone Nov 18, 2020
@rousseldenis
[10.0][IMP] stock_auto_move: auto_confirm=>auto_move
db11166 
As in v>=12, stock.location.path and procurement.rule have been merged
into stock.rule, use the same field name.
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022
@github-actions github-actions bot closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

Assignees
No one assigned
Labels
enhancement needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rousseldenis @ThomasBinsfeld @zakiuu