[16.0][ADD] stock_move_negative_stock_location #1801
Conversation
santostelmo
force-pushed
the
16.0-add-stock_move_negative_location
branch
from
bc7b2db to
6912963
Compare
santostelmo
force-pushed
the
16.0-add-stock_move_negative_location
branch
from
6912963 to
b87153c
Compare
santostelmo
changed the title
|
@santostelmo @jbaudoux Thanks for this. But, shouldn't it be a "bug" in stock module behavior ? |
You're absolutely right ! I am opening a issue to odoo. In the meantime we have this module to workaround. |
| # #L1381C14-L1381C27) | ||
| # to be able to invert location_id and location_dest_id | ||
| if self.env.context.get("neg_r_moves"): | ||
| self.set_negative_return_moves_location() |
There was a problem hiding this comment.
And handle the context only where it is needed (if in later version Odoo adds a hook for instance, we could trash easily this context handling without touching the business method set_negative_return_moves_location:
| self.set_negative_return_moves_location() | |
| neg_moves = self.browse(self.env.context.get("neg_r_moves")).exists() | |
| neg_moves.set_negative_return_moves_location() |
| neg_r_moves = self.browse(self.env.context["neg_r_moves"]) | ||
| for move in neg_r_moves: |
There was a problem hiding this comment.
Better to get methods not depending on context but on current recordset, easier to test and understand:
| neg_r_moves = self.browse(self.env.context["neg_r_moves"]) | |
| for move in neg_r_moves: | |
| for move in self: |
| @@ -0,0 +1,3 @@ | |||
| When making an stock move with a negative quantity, odoo convert it to a positive return move and the locations are inverted. | |||
There was a problem hiding this comment.
| When making an stock move with a negative quantity, odoo convert it to a positive return move and the locations are inverted. | |
| When making a stock move with a negative quantity, Odoo converts it to a positive return move and the locations are inverted. |
| location_source = self.env.ref("stock.stock_location_stock") | ||
| location_dest = self.env.ref("stock.stock_location_customers") | ||
|
|
||
| # WH: Stock → Customers | ||
| rule = self.env["stock.rule"].search( | ||
| [ | ||
| ("action", "=", "pull"), | ||
| ("picking_type_id", "=", self.env.ref("stock.picking_type_out").id), | ||
| ("location_src_id", "=", location_source.id), | ||
| ("location_dest_id", "=", location_dest.id), | ||
| ("procure_method", "=", "make_to_stock"), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
These config data can be retrieved in setUpClass, to keep transactional data and asserts only in the test
Context
When making an stock move with a negative quantity, odoo convert it to a positive return move and the locations are inverted.
For stock moves with negative quantities, this module sets the source location with the return
picking type default destination location. Like that destination location is properly set on the return move.
Usage
In
Returnspicking type set the default destination location asStockCreate a stock move from Stock to Customer with a negative quantity and validate it.
That move will be converted into a stock move from Customer to Stock with a positive quantity.