Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_auto_move #1797

Open
wants to merge 40 commits into
base: 17.0
Choose a base branch
from

Conversation

ferran-S73
Copy link
Contributor

Standard migration. Deleted the _get_auto_moves_by_pickings method because it was no longer used in this module

npiganeau and others added 30 commits December 19, 2024 12:26
* The `_apply` method should not be overridden. In case of three step
operation with the last step set to auto move. The override of the
`_apply` method was causing the second move to be automatic as well.

**Use case**: doing a reception operation in two steps where the moves on
the second step are set to be automatic (using the push rule in this
case), and the reception is done partially.
**Expected Result**: When doing a first reception step partially a back
order is created, and we expect the second step to have a back order for
the remaining qty as well.
**Current behavior**: The correct move is processed automatically but no
backorder is created. The reason for that behavior is we processing the
move directly (i.e calling `action_done` of the `stock.move`) without
going through the normal process (i.e processing the second step
picking).
**The solution to the problem**: The processing the of the automatic
stock move should follow the same behavior as done from the user interface.
I've added a new function in `stock.picking` model called
`_transfer_pickings_with_auto_move` to simulate the same behavior this
function is called inside the `action_assign` of the stock move instead
of calling the `action_done` of the move.
As in v>=12, stock.location.path and procurement.rule have been merged
into stock.rule, use the same field name.
If moves were created with a particular procurment group, don't
change it to automatic one. Do it only if it's void.
As unit of measure can be a different multiple than reference,
use product_uom_qty instead.
If in a first picking, we transfer partially one quantity and
say 'No backorder', the destination move should be split and
cancelled for the remaining quantities if 'propagate_cancel'
is set.
… (take2)

In case of partial flows with move cancel and mixed moves (auto and manual),
we need to create a backorder for manual quantities to not get a picking
with moves with mixed states (done, cancel, assigned).

We remove code that is never called on picking side
Currently translated at 100.0% (12 of 12 strings)

Translation: stock-logistics-workflow-14.0/stock-logistics-workflow-14.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-14-0/stock-logistics-workflow-14-0-stock_auto_move/ca/
OCA-git-bot and others added 9 commits December 19, 2024 12:26
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-14.0/stock-logistics-workflow-14.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-14-0/stock-logistics-workflow-14-0-stock_auto_move/
Currently translated at 100.0% (11 of 11 strings)

Translation: stock-logistics-workflow-14.0/stock-logistics-workflow-14.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-14-0/stock-logistics-workflow-14-0-stock_auto_move/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_auto_move/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_auto_move/
Currently translated at 100.0% (8 of 8 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_auto_move
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_auto_move/pt_BR/
@ferran-S73 ferran-S73 mentioned this pull request Dec 19, 2024
61 tasks
@ferran-S73 ferran-S73 force-pushed the 17.0-mig-stock_auto_move branch from bbf0e71 to 087c6e6 Compare December 19, 2024 12:40
@rousseldenis
Copy link
Contributor

/ocabot migration stock_auto_move

@@ -69,8 +69,11 @@ def test_10_auto_move(self):
}
)
move3._action_confirm()
self.env["stock.quant"]._update_available_quantity(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferran-S73 Why is this necessary ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis The move was not reserving stock because there was no available stock of the product. Maybe in older versions some other module added stock for the product?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.