[17.0][MIG] stock_lot_production_date: Migration to 17.0 #1683
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_lot_production_date Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_lot_production_date/it/
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_lot_production_date Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_lot_production_date/ca/
Currently translated at 66.6% (2 of 3 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_lot_production_date Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_lot_production_date/es/
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_lot_production_date Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_lot_production_date/es/
|
/ocabot migration stock_lot_production_date |
SodexisTeam
force-pushed
the
17.0-mig-stock_lot_production_date
branch
from
fdb3992 to
aea2649
Compare
|
Hi, @moylop260, please, could you merge it? |
stock_lot_production_date/README.rst
Outdated
| @@ -67,6 +67,7 @@ Contributors | |||
| ------------ | |||
|
|
|||
| - Sébastien Alix <[email protected]> | |||
| - SodexisTeam <[email protected]> | |||
There was a problem hiding this comment.
Please, remove the contributor change but add as maintainer
I mean, add a input in the __manifest__.py file with:
"maintainers": ["SodexisTeam"],
There was a problem hiding this comment.
Also the change in the index.html
There was a problem hiding this comment.
@moylop260 This is not correct.
The philosophy behind "maintainers" is that should use individual github accounts, not organization ones.
There was a problem hiding this comment.
@rousseldenis We are going to follow your advice and start using individual account.
There was a problem hiding this comment.
@SodexisTeam yes, indeed, declaring a PR with organization account seems OK, but contributors and maintainers should rely on individual accounts. The company can appear on authors part when applicable.
There was a problem hiding this comment.
@rousseldenis This is not correct.
Thank you for your advice, I didn't know it
Could you refer your advice, please? (I didn't find any related with this "not correct")
We are going to follow your advice and start using individual ACC
@SodexisTeam will you change it the value in maintainer?
There was a problem hiding this comment.
@moylop260 We are working on it.
SodexisTeam
force-pushed
the
17.0-mig-stock_lot_production_date
branch
from
aea2649 to
a1df4be
Compare
| @@ -8,5 +8,6 @@ class StockProductionLot(models.Model): | |||
| _inherit = "stock.lot" | |||
|
|
|||
| production_date = fields.Datetime( | |||
| help="This is the date when the goods with this lot/serial number have been produced." | |||
| help="This is the date when the goods with this \ | |||
There was a problem hiding this comment.
Revert this change to original way, please
The original line is good for our guidelines
There was a problem hiding this comment.
@moylop260 We have issue with pre-commit in this line so we used the "", now we have removed that. Please check once again.
There was a problem hiding this comment.
What issue?
I mean, the length of the line is good for the guidelines defined but not sure what was the problem?
There was a problem hiding this comment.
@moylop260 The error we got is
ruff.....................................................................Failed
hook id: ruff
exit code: 1
stock_lot_production_date/models/stock_lot.py:11:89: E501 Line too long (94 > 88)
Found 1 error.
Actual length of the line in our file is 94 but in the .ruff.toml file it is mentioned that "E501", # line too long (default 88).
There was a problem hiding this comment.
@sbidoul Did we change to length 88 or it was a default hidden?
There was a problem hiding this comment.
I don't think we changed anything in that area recently. Probably ruff and black+flake8 have a slightly different interpretation.
|
@sebalix Do you agree the maintainers change(adoption) ? |
SodexisTeam
force-pushed
the
17.0-mig-stock_lot_production_date
branch
from
a1df4be to
9448b13
Compare
SodexisTeam
force-pushed
the
17.0-mig-stock_lot_production_date
branch
from
9448b13 to
87cccbe
Compare
|
Any blocking comment? |
|
Hi, what happened with PR? could we merge it? @SodexisTeam @moylop260 |
atchuthan
force-pushed
the
17.0-mig-stock_lot_production_date
branch
from
87cccbe to
df71060
Compare
|
@moylop260 could you review again? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2a301db. Thanks a lot for contributing to OCA. ❤️ |
No description provided.