[16.0][MIG] stock_picking_auto_create_lot_qty #1567

dessanhemrayev · 2024-04-10T22:14:34Z

Migration to 16.0

rousseldenis · 2024-04-11T08:54:07Z

/ocabot migration stock_picking_auto_create_lot_qty

rousseldenis · 2024-04-11T08:55:58Z

@dessanhemrayev Thanks for this. Could you point to the depending PR(s) in this one description in order to make review easier ?

Bearnard21

Steps to reproduce

Add a few products to the purchase order for instance Line 1: Whiskey qty: 5 and Line 2: Beer qty: 5
Create a picking
Validate a picking

Expected behaviour

Lot's are split for both products and serial numbers assigned

Current behaviour

The beer quantity will be added to the whiskey. So you will get 10 whiskey received and 0 beer.

Bearnard21

Please fix an issue decribed above

Bearnard21

Functionality LGTM

dmitriypaulov

Code LGTM, good job!

dessanhemrayev · 2024-05-16T20:50:07Z

@dessanhemrayev Thanks for this. Could you point to the depending PR(s) in this one description in order to make review easier ?

@rousseldenis I have updated the description)
check please)

Bearnard21 · 2024-06-07T12:28:54Z

@rousseldenis Could you please check the PR. Thnx

hoangtrann

Looks good in general, well done 💯

stock_picking_auto_create_lot_qty/models/stock_picking.py

stock_picking_auto_create_lot_qty/README.rst

stock_picking_auto_create_lot_qty/models/stock_picking.py

hoangtrann · 2024-07-02T17:17:42Z

stock_picking_auto_create_lot_qty/models/stock_picking.py

+        """
+        Allows to be called either by button or through code
+        """


docstring is incomplete, please provide what this function does

Thanks, I'll fix it

hoangtrann · 2024-07-02T17:20:26Z

stock_picking_auto_create_lot_qty/models/product_template.py

+    batch_uom_id = fields.Many2one(
+        string="Uom",
+        help="The unit of measure used when creating batches.",
+        comodel_name="uom.uom",


why do we need this?

This is one of the conditions of the customer, it is necessary to create a batch

stock_picking_auto_create_lot_qty/readme/CONFIGURE.md

stock_picking_auto_create_lot_qty/readme/USAGE.md

OCA-git-bot · 2024-07-05T21:07:28Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hoangtrann · 2024-07-06T06:15:52Z

stock_picking_auto_create_lot_qty/README.rst

+#. Go to *Inventory > Master Data > Products*, select a product. #. Set
+'Auto create lot' option, and set 'Create lot every' count of UoMs for
+the products you need. #. Go the *Settings > Inventory > Stock Serial
+Lot*. #. Press --> Sequences button to create/configure your lot
+sequence for a company in 'ir.sequence' module. The default sequence is
+'stock.lot.serial'. #. Once a sequence is created/updated select the
+stock lot sequence for the current company.


these still won't appear correctly on the web view, can you fix this?

Thanks,I'll fix it

hoangtrann · 2024-07-06T06:16:00Z

stock_picking_auto_create_lot_qty/README.rst

+#. Go to *Inventory* tab of a product. #. Set a tracking option for this
+product. #. Set 'Auto create lot'. #. Go to *Inventory > Incoming* and
+create a new transfer. #. Validate picking without lot. #. If 'Only
+multiples allowed' has been selected in the product, picking validation
+will be blocked if qty received is not a multiple of the value set in
+the product.


these still won't appear correctly on the web view, can you fix this?

I'll fix it

rousseldenis · 2024-09-09T07:43:47Z

@rousseldenis Please merge PR. Thank you.

@Bearnard21 This PR seems to depends on #1565

dessanhemrayev · 2024-09-09T13:13:48Z

@rousseldenis Please merge PR. Thank you.

@Bearnard21 This PR seems to depends on #1565

Hi @rousseldenis )
Thanks
Now this PR does not depend on PR #1565

hoangtrann

Code LGTM, tested and it run as expected 👍

dessanhemrayev · 2024-10-14T19:23:07Z

@rousseldenis check please)

ivs-cetmix · 2024-12-09T22:54:39Z

Hello @OCA/logistics-maintainers any chances to have this reviewed and merged? )

sebalix

Migration LG, but we are missing some git commits (translations) and pre-commit commit doesn't include the name of the module updated, and its content seems wrong (probably because the history of 14.0 branch wasn't well retrieved).

https://github.com/OCA/stock-logistics-workflow/commits/14.0/stock_picking_auto_create_lot_qty

Can you check this please?

ivs-cetmix · 2024-12-10T11:54:50Z

Migration LG, but we are missing some git commits (translations) and pre-commit commit doesn't include the name of the module updated, and its content seems wrong (probably because the history of 14.0 branch wasn't well retrieved).

https://github.com/OCA/stock-logistics-workflow/commits/14.0/stock_picking_auto_create_lot_qty

Can you check this please?

Sure, thank you for the feedback!

rvalyi · 2024-12-19T19:42:08Z

@ivs-cetmix it seems you messed it up in your last commit: you merged the 16,0 branch in your migration branch instead of rebasing the migration branch onto 16.0...

Assuming you were on your migration branch, you should have done:

git fetch origin 16.0:16.0
git rebase 16.0

As for now you should delete the merge commit. It can be done with git rebase -I for instance.,,

Allow create lots for every n count of product This case covered with tests

dessanhemrayev · 2024-12-19T20:23:50Z

@rvalyi Thanks)
Is it okay now?

rvalyi · 2024-12-19T21:06:03Z

@rvalyi Thanks)
Is it okay now?

as for the commit it looks OK. I would have expected the weblate translations to come before the migration commits but it's not a big deal either.

rvalyi

almost OK but as per the migration to v15 step you should have replaced SavePointCase by TransactionCase is the tests, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

rousseldenis · 2024-12-20T07:53:00Z

@dessanhemrayev Could you remove all the commits concerning other modules (translations)? Thanks

dessanhemrayev · 2024-12-20T21:08:04Z

almost OK but as per the migration to v15 step you should have replaced SavePointCase by TransactionCase is the tests, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Hi @rvalyi
In tests I use TransactionCase
maybe I don't understand you?

dessanhemrayev · 2024-12-20T21:35:55Z

Migration LG, but we are missing some git commits (translations) and pre-commit commit doesn't include the name of the module updated, and its content seems wrong (probably because the history of 14.0 branch wasn't well retrieved).

https://github.com/OCA/stock-logistics-workflow/commits/14.0/stock_picking_auto_create_lot_qty

Can you check this please?

Hi @sebalix
Thanks for feedback!

could you tell me how I can correctly restore these commits, maybe it would be better for me to do the migration again on the new PR?

rvalyi · 2024-12-20T22:35:13Z

almost OK but as per the migration to v15 step you should have replaced SavePointCase by TransactionCase is the tests, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Hi @rvalyi
In tests I use TransactionCase
maybe I don't understand you?

Hum indeed, sorry it seems I looked at a bad place I think.

I was mistaken

OCA-git-bot · 2024-12-20T23:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dessanhemrayev mentioned this pull request Apr 10, 2024

[16.0][FIX] stock_picking_auto_create_lot: create new serial number for lots #1565

Closed

OCA-git-bot added this to the 16.0 milestone Apr 11, 2024

OCA-git-bot mentioned this pull request Apr 11, 2024

Migration to version 16.0 #1101

Open

70 tasks

Bearnard21 approved these changes Apr 11, 2024

View reviewed changes

Bearnard21 suggested changes Apr 13, 2024

View reviewed changes

Bearnard21 approved these changes Apr 14, 2024

View reviewed changes

dmitriypaulov approved these changes Apr 17, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 17, 2024

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch 4 times, most recently from 48108b4 to 843db6e Compare June 15, 2024 15:56

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch from de2cbde to 70b702f Compare June 30, 2024 21:49

hoangtrann reviewed Jul 2, 2024

View reviewed changes

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch 2 times, most recently from 4461f75 to 3f09ce6 Compare July 4, 2024 19:14

OCA-git-bot added the ready to merge label Jul 5, 2024

hoangtrann suggested changes Jul 6, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jul 6, 2024

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch 2 times, most recently from 1aefc28 to b6c469f Compare July 6, 2024 12:15

hoangtrann approved these changes Jul 8, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 8, 2024

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch 2 times, most recently from 5981be7 to 4eacb70 Compare September 8, 2024 17:04

hoangtrann approved these changes Sep 10, 2024

View reviewed changes

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch from 4eacb70 to 7cd2113 Compare October 14, 2024 19:27

sebalix reviewed Dec 10, 2024

View reviewed changes

aayartsev and others added 3 commits December 19, 2024 23:14

[ADD] stock_picking_auto_create_lot_qty: new module

bf31df3

Allow create lots for every n count of product This case covered with tests

[IMP] : pre-commit stuff

dcb0f00

[MIG] stock_picking_auto_create_lot_qty: Migration to 16.0

9745b15

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch from 0ebe551 to 5ab04d2 Compare December 19, 2024 20:15

rvalyi previously requested changes Dec 19, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Dec 19, 2024

dessanhemrayev force-pushed the 16.0-t3463-stock_picking_auto_create_lot_qty-migration branch from 5ab04d2 to 9745b15 Compare December 20, 2024 21:04

OCA-git-bot added approved ready to merge labels Dec 20, 2024

dessanhemrayev requested a review from sebalix December 27, 2024 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] stock_picking_auto_create_lot_qty #1567

[16.0][MIG] stock_picking_auto_create_lot_qty #1567

dessanhemrayev commented Apr 10, 2024 •

edited

Loading

rousseldenis commented Apr 11, 2024

rousseldenis commented Apr 11, 2024

Bearnard21 left a comment •

edited

Loading

Bearnard21 left a comment

Bearnard21 left a comment

dmitriypaulov left a comment

dessanhemrayev commented May 16, 2024 •

edited

Loading

Bearnard21 commented Jun 7, 2024

hoangtrann left a comment

hoangtrann Jul 2, 2024

dessanhemrayev Jul 2, 2024

hoangtrann Jul 2, 2024

dessanhemrayev Jul 2, 2024

OCA-git-bot commented Jul 5, 2024

hoangtrann Jul 6, 2024

dessanhemrayev Jul 6, 2024

hoangtrann Jul 6, 2024

dessanhemrayev Jul 6, 2024

rousseldenis commented Sep 9, 2024

dessanhemrayev commented Sep 9, 2024

hoangtrann left a comment

dessanhemrayev commented Oct 14, 2024

ivs-cetmix commented Dec 9, 2024

sebalix left a comment •

edited

Loading

ivs-cetmix commented Dec 10, 2024

rvalyi commented Dec 19, 2024 •

edited

Loading

dessanhemrayev commented Dec 19, 2024

rvalyi commented Dec 19, 2024

rvalyi left a comment •

edited

Loading

rousseldenis commented Dec 20, 2024

dessanhemrayev commented Dec 20, 2024

dessanhemrayev commented Dec 20, 2024

rvalyi commented Dec 20, 2024

OCA-git-bot commented Dec 20, 2024

[16.0][MIG] stock_picking_auto_create_lot_qty #1567

Are you sure you want to change the base?

[16.0][MIG] stock_picking_auto_create_lot_qty #1567

Conversation

dessanhemrayev commented Apr 10, 2024 • edited Loading

rousseldenis commented Apr 11, 2024

rousseldenis commented Apr 11, 2024

Bearnard21 left a comment • edited Loading

Choose a reason for hiding this comment

Bearnard21 left a comment

Choose a reason for hiding this comment

Bearnard21 left a comment

Choose a reason for hiding this comment

dmitriypaulov left a comment

Choose a reason for hiding this comment

dessanhemrayev commented May 16, 2024 • edited Loading

Bearnard21 commented Jun 7, 2024

hoangtrann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Sep 9, 2024

dessanhemrayev commented Sep 9, 2024

hoangtrann left a comment

Choose a reason for hiding this comment

dessanhemrayev commented Oct 14, 2024

ivs-cetmix commented Dec 9, 2024

sebalix left a comment • edited Loading

Choose a reason for hiding this comment

ivs-cetmix commented Dec 10, 2024

rvalyi commented Dec 19, 2024 • edited Loading

dessanhemrayev commented Dec 19, 2024

rvalyi commented Dec 19, 2024

rvalyi left a comment • edited Loading

Choose a reason for hiding this comment

rousseldenis commented Dec 20, 2024

dessanhemrayev commented Dec 20, 2024

dessanhemrayev commented Dec 20, 2024

rvalyi commented Dec 20, 2024

OCA-git-bot commented Dec 20, 2024

dessanhemrayev commented Apr 10, 2024 •

edited

Loading

Bearnard21 left a comment •

edited

Loading

dessanhemrayev commented May 16, 2024 •

edited

Loading

sebalix left a comment •

edited

Loading

rvalyi commented Dec 19, 2024 •

edited

Loading

rvalyi left a comment •

edited

Loading