[17.0][MIG] stock_production_lot_active: Migration to 17.0 #1487
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_production_lot_active Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_production_lot_active/it/
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
/ocabot migration stock_production_lot_active |
| active = fields.Boolean(default=True) | ||
|
|
||
| @api.constrains("name", "product_id", "company_id") | ||
| def _check_unique_lot(self): |
There was a problem hiding this comment.
@laszlokr Why removing this?
There was a problem hiding this comment.
@rousseldenis this check seems to be redundant, as by default it is not possible to have the same product with identical lot/serial number. I tested the module with and without this method, the behavior is exactly same
There was a problem hiding this comment.
Have you tested with inactive lots ?
As in standard, it seems inactive lots are not tested:
There was a problem hiding this comment.
@rousseldenis apologies for my delayed response. Indeed, it might still be needed, so I restored the method and also renamed the class according to the change of model name
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
| bg_color="bg-danger" | ||
| invisible="active == True" |
There was a problem hiding this comment.
Just a minor comment: on standard Odoo code, this is the way the ribbon is defined:
| bg_color="bg-danger" | |
| invisible="active == True" | |
| bg_color="text-bg-danger" | |
| invisible="active" |
Not blocking for me, so I approved the PR.
github-actions
bot
removed
the
stale
Standard migration from 15.0 to 17.0.