Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_invoice_link: Migration to 17.0 #1446

Merged

Conversation

lethuthao2403
Copy link

ref: BSRD-699

eLBati and others added 30 commits November 29, 2023 11:08
partially by creating i18n folder first
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
… is cancelled its pickings go back to "to2invoiced" state * If a cancelled invoice goes back again to draft, its pickings are marked as invoiced to avoid invoicing twice * Not able to erase an invoice with pickings not cancelled * Tests

stock_picking_invoice_link: unlink improved * enable erasing when invoice is in state 'draft' or 'cancel' * if invoice is in state 'draft', not cancelled picking will be invoiceable
… references

For dropshipping pickings with module stock_dropshipping_dual_invoice, you generate
two invoices for the same picking, so the many2one only reflects the last generated
invoice. With this change, now both are linked.
…#296)

Previous migration did not keep the business functionality of the previous module. Link from invoice to picking must link only related delivery and not all deliveries in case of partial delivery
avoiding 'product.service_delivery' because not useful in tests and correctly handled as service by 10.0 tests
Currently translated at 100.0% (12 of 12 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_invoice_link/pt_BR/
weblate and others added 10 commits November 29, 2023 11:47
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/
Currently translated at 100.0% (18 of 18 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/fr/
Currently translated at 100.0% (18 of 18 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/es/
Currently translated at 100.0% (18 of 18 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/
Currently translated at 100.0% (18 of 18 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/es/
Currently translated at 100.0% (18 of 18 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/it/
@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_invoice_link

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 1, 2023
62 tasks
@lethuthao2403 lethuthao2403 force-pushed the 17.0-mig-stock_picking_invoice_link branch from eb6cd32 to fa2abbe Compare December 5, 2023 08:08
@lethuthao2403 lethuthao2403 force-pushed the 17.0-mig-stock_picking_invoice_link branch from fa2abbe to b1ead6a Compare December 5, 2023 08:32
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1446-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 622c18a. Thanks a lot for contributing to OCA. ❤️

@loicgrifnee
Copy link

There seems to be an error in the way of overriding the reverse_moves method.

def reverse_moves(self, is_modify=False):
     action = super(
           AccountMoveReversal, self.with_context(force_copy_stock_moves=True)
     ).reverse_moves()

By not passing the is_modify=is_modify parameter, this prevents proper functioning.

@ferran-S73
Copy link
Contributor

There seems to be an error in the way of overriding the reverse_moves method.

def reverse_moves(self, is_modify=False):
     action = super(
           AccountMoveReversal, self.with_context(force_copy_stock_moves=True)
     ).reverse_moves()

By not passing the is_modify=is_modify parameter, this prevents proper functioning.

Fixed in

@lethuthao2403 @gurneyalex could you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.