Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] announcement: Migration to 17.0 #935

Merged
merged 21 commits into from
Sep 3, 2024

Conversation

chienandalu
Copy link
Member

cc @Tecnativa TT50049

@pedrobaeza
Copy link
Member

/ocabot migration announcement

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 2, 2024
24 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally is OK. About the formal aspect, you have to split the pre-commit auto-fixes in one commit, and the migration into another.

chienandalu and others added 20 commits September 3, 2024 10:58
- Now that the reads count is stored, we need to add a depends that
triggers the recomputation. To do so, we need to link announcements and
read logs.
- Simplified popup on log in mechanism.
- The notification_expiry_date field was duplicated in the form view
- Add some thechnical suggestions
- Change the term `pendant` to a more convenient `unread`
- Regular users can't read announcements with dates in the future or
which expiration date has passed nor archived announcements.
- Fix typos

TT38174
If a user has an announcement open in multiple windows, the read will be
logged multiple times. The relevant one is only the first one.

TT38705
There's a soft compatibility with OCA's `web_dialog_size` module. If the instance has
the module installed, you'll have the dialog resize controls by default in the
announcements. Additionally, you can show the announcement dialogs expanded to the
screen full width by default setting the system parameter key `announcement.full_size`
with to any value. Remove the parameter record to disable this behavior.

TT39634
Currently translated at 100.0% (52 of 52 strings)

Translation: server-ux-15.0/server-ux-15.0-announcement
Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-announcement/es/
A new field "is_general_announcement" is added which when checked sends
the announcement to users belonging to the "Internal User" group.

TT42581
A new field has been added to be able to attach files to the
announcement, and these attachments will be displayed in
the announcement notification modal.

TT42581
Example of use case:
- Create an announcement to a user
- Archive the user
- When accessing the advertisement, we want to know the user(s) even if he/she is now archived.

TT49077
@chienandalu chienandalu force-pushed the 17.0-mig-announcement branch from bf07508 to 33bb3f7 Compare September 3, 2024 09:12
@chienandalu
Copy link
Member Author

you have to split the pre-commit auto-fixes in one commit

done

@chienandalu chienandalu force-pushed the 17.0-mig-announcement branch from 33bb3f7 to 2577de3 Compare September 3, 2024 14:37
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-935-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ce99e6d into OCA:17.0 Sep 3, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7d0ac57. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-announcement branch September 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants