-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] announcement: Migration to 17.0 #935
Conversation
b08c3ac
to
bf07508
Compare
/ocabot migration announcement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally is OK. About the formal aspect, you have to split the pre-commit auto-fixes in one commit, and the migration into another.
- Now that the reads count is stored, we need to add a depends that triggers the recomputation. To do so, we need to link announcements and read logs. - Simplified popup on log in mechanism. - The notification_expiry_date field was duplicated in the form view - Add some thechnical suggestions - Change the term `pendant` to a more convenient `unread` - Regular users can't read announcements with dates in the future or which expiration date has passed nor archived announcements. - Fix typos TT38174
If a user has an announcement open in multiple windows, the read will be logged multiple times. The relevant one is only the first one. TT38705
There's a soft compatibility with OCA's `web_dialog_size` module. If the instance has the module installed, you'll have the dialog resize controls by default in the announcements. Additionally, you can show the announcement dialogs expanded to the screen full width by default setting the system parameter key `announcement.full_size` with to any value. Remove the parameter record to disable this behavior. TT39634
Currently translated at 100.0% (52 of 52 strings) Translation: server-ux-15.0/server-ux-15.0-announcement Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-announcement/es/
A new field "is_general_announcement" is added which when checked sends the announcement to users belonging to the "Internal User" group. TT42581
A new field has been added to be able to attach files to the announcement, and these attachments will be displayed in the announcement notification modal. TT42581
Doing them to be owned by the record.
Example of use case: - Create an announcement to a user - Archive the user - When accessing the advertisement, we want to know the user(s) even if he/she is now archived. TT49077
bf07508
to
33bb3f7
Compare
done |
33bb3f7
to
2577de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7d0ac57. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT50049