Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][FIX] auditlog: Allow passing a chunk size for autovacuum #2591

Merged
merged 3 commits into from
Apr 18, 2023
Merged

[13.0][FIX] auditlog: Allow passing a chunk size for autovacuum #2591

merged 3 commits into from
Apr 18, 2023

Conversation

BT-tbaechle
Copy link

@BT-tbaechle BT-tbaechle commented Mar 22, 2023 •
edited
Loading

(cherry picked from commit d4f8eb3)
The commit was already cherry-picked into all branches v14+, only v13 is missing.

Original PR in v12 #2335

This allows administrators to fine tune the amount of records to delete in one run of the autovacuum.

@sebalix sebalix added this to the 13.0 milestone Apr 4, 2023
BT-dmoreno
BT-dmoreno approved these changes Apr 11, 2023
View reviewed changes
Copy link

@BT-dmoreno BT-dmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 , just wondering about the use of norecompute since I see it's marked as deprecated in the method definition.

@BT-tbaechle
Copy link
Author

Looks good to me +1 , just wondering about the use of norecompute since I see it's marked as deprecated in the method definition.

This commit is already migrated to all versions 14+ and all still include the norecompute so assumed it would be fine to keep it.

BT-mgomez
BT-mgomez approved these changes Apr 11, 2023
View reviewed changes
Copy link

@BT-mgomez BT-mgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-tbaechle
Copy link
Author

Hi @hbrunn do you think this can be merged?

@hbrunn
Copy link
Member

hbrunn commented Apr 18, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-2591-by-hbrunn-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f5f4085 into OCA:13.0 Apr 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9bc8f3e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-dmoreno BT-dmoreno BT-dmoreno approved these changes

@BT-mgomez BT-mgomez BT-mgomez approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BT-tbaechle @OCA-git-bot @hbrunn @BT-mgomez @BT-dmoreno @sebalix