Skip to content

Commit

Permalink
[IMP] upgrade_analysis : prefill status with trivial information
Browse files Browse the repository at this point in the history
  • Loading branch information
legalsylvain committed Nov 15, 2021
1 parent ef0c459 commit 0d77336
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 6 deletions.
31 changes: 27 additions & 4 deletions upgrade_analysis/models/upgrade_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ def analyze(self):
}
general_log = ""

no_changes_modules = []

for ignore_module in _IGNORE_MODULES:
if ignore_module in keys:
keys.remove(ignore_module)
Expand All @@ -232,6 +234,7 @@ def analyze(self):
contents += "\n"
if key not in res and key not in res_xml and key not in res_model:
contents += "---nothing has changed in this module--\n"
no_changes_modules.append(key)
if key == "general":
general_log += contents
continue
Expand Down Expand Up @@ -267,7 +270,7 @@ def analyze(self):
general_log += "ERROR: error when generating noupdate changes: %s\n" % e

try:
self.generate_module_coverage_file()
self.generate_module_coverage_file(no_changes_modules)
except Exception as e:
_logger.exception("Error generating module coverage file: %s" % e)
general_log += "ERROR: error when generating module coverage file: %s\n" % e
Expand Down Expand Up @@ -502,7 +505,7 @@ def generate_noupdate_changes(self):
)
return True

def generate_module_coverage_file(self):
def generate_module_coverage_file(self, no_changes_modules):
self.ensure_one()

module_coverage_file_folder = config.get("module_coverage_file_folder", False)
Expand Down Expand Up @@ -538,15 +541,34 @@ def generate_module_coverage_file(self):
end_version = release.major_version

all_modules = sorted(list(set(all_remote_modules + all_local_modules)))
module_descriptions = []
module_descriptions = {}
for module in all_modules:
status = ""
if module in all_local_modules and module in all_remote_modules:
module_description = " %s" % module
elif module in all_local_modules:
module_description = " |new| %s" % module
else:
module_description = " |del| %s" % module
module_descriptions.append(module_description.ljust(49, " "))

if module in compare.apriori.merged_modules:
status = "Merged into %s. " % compare.apriori.merged_modules[module]
elif module in compare.apriori.renamed_modules:
status = "Renamed to %s. " % compare.apriori.renamed_modules[module]
elif module in compare.apriori.renamed_modules.values():
status = (
"Renamed from %s. "
% [
x
for x in compare.apriori.renamed_modules
if compare.apriori.renamed_modules[x] == module
][0]
)
if module in no_changes_modules:
status += "No changes. "
module_descriptions[module_description.ljust(49, " ")] = status.ljust(
49, " "
)

rendered_text = file_template.render(
start_version=start_version,
Expand All @@ -563,3 +585,4 @@ def generate_module_coverage_file(self):
f = open(file_path, "w+")
f.write(rendered_text)
f.close()
return True
4 changes: 2 additions & 2 deletions upgrade_analysis/static/src/module_coverage_template.rst.mako
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Module coverage ${start_version} -> ${end_version}
+-------------------------------------------------+-------------------------------------------------+
|Module |Status |
+=================================================+=================================================+
% for module_description in module_descriptions:
|${module_description}| |
% for module, status in module_descriptions.items():
|${module}|${status}|
+-------------------------------------------------+-------------------------------------------------+
% endfor

0 comments on commit 0d77336

Please sign in to comment.