Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [16.0] sale_order_line_effective_date: Add commitment date #3215

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Jun 28, 2024

Add real commitment date to the lines.

Is just a relation with the real commitment date.

Checked with sale_order_line_date module and doesn't do the same. This only adds the real commitment date set on the order. The other one performs another operations.

MT-6075 @moduon @rafaelbn @Gelojr @fcvalgar please review if you want :)

@OCA-git-bot
Copy link
Contributor

Hi @EmilioPascual, @rafaelbn,
some modules you are maintaining are being modified, check this out!

@Shide Shide changed the title [FIX] [16.0] sale_order_line_effective_date: Add commmitment date [FIX] [16.0] sale_order_line_effective_date: Add commitment date Jul 1, 2024
@Shide Shide force-pushed the 16.0-add_commitment_date-sale_order_line_effective_date branch from f52b348 to b921e96 Compare July 2, 2024 06:26
Copy link
Contributor

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3215-by-yajo-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 09ce985 into OCA:16.0 Jul 2, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f6d8723. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-add_commitment_date-sale_order_line_effective_date branch July 2, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants