-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale cancel reason #3062
Conversation
(../trunk-generic/ rev 29.1.1)
(../trunk-generic/ rev 32.1.1)
(../trunk-generic/ rev 32.1.2)
- Update travis.yml to 8.0
Only hide button instead of renaming it
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
… of sale_cancel_reason module
* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2
Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sale order. | ||
</p> | ||
<group> | ||
<field name="reason_id" widget="selection" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the selection widget. With many records, filtering becomes complicated, and not all records are displayed.
<field name="reason_id" widget="selection" /> | |
<field name="reason_id" options="{'no_create': True, 'no_open': True}" /> |
61340f5
to
b6b1615
Compare
Hello @celm1990 , thank you for your review! I added possibility to choose cancel reason on mass quotation cancel wizard. |
/ocabot migration sale_cancel_reason |
sale_cancel_reason/__manifest__.py
Outdated
@@ -5,7 +5,7 @@ | |||
|
|||
{ | |||
"name": "Sale Cancel Reason", | |||
"version": "16.0.1.0.1", | |||
"version": "17.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we reset to 17.0.1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, both wizard fields must be the same (either many2one with widget=selection or not)
<field name="arch" type="xml"> | ||
<footer position="before"> | ||
<group> | ||
<field name="reason_id" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about it, thanks.
866d216
to
4be9715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4be9715
to
2d15d00
Compare
This PR has the |
@rousseldenis , since it's approved, could you merge? |
@celm1990 FYI, if the commit is reflecting an improvement or is not related to the preceding one (migration), it's common to let them in place. As maybe, it can be easily forward/backported. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2149146. Thanks a lot for contributing to OCA. ❤️ |
No description provided.