[11.0][FIX] sale_global_discount: Constraint tax lines combinations #1181
Conversation
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
pedrobaeza
force-pushed
the
11.0-sale_global_discount-tax_lines
branch
from
7e9371b to
43c7596
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 9fec3f8. Thanks a lot for contributing to OCA. ❤️ |
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early.
OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest.
We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
@Tecnativa TT24526