-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] loyalty_partner_applicability #231
Open
sbejaoui
wants to merge
13
commits into
OCA:18.0
Choose a base branch
from
acsone:18.0-loyalty_partner_applicability-sbj
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me entity There's a new configuration option in the settings to allow sharing coupons between members of the same trading entity. It has to be in the base module for being shared between all the rest of applications, but each *_applicability module will contain extra bits of code to use it. TT45413
…main rule It is necessary to establish the default value, in this case "[ ]" to the rule_partners_domain field, in the create method for the rules established in the computed method "_program_type_default_values" that establishes the default values depending on the type of program, because when creating a new program, these rules do not have the rule_partners_domain field defined, as it is not contemplated, its value will be "False", which cannot be interpreted as a correct domain. To avoid this error, the check is made in the create method and the correct value is added. TT44344
Currently translated at 100.0% (5 of 5 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-loyalty_partner_applicability Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-loyalty_partner_applicability/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.