[17.0][MIG] loyalty_partner_applicability: Migration to 17.0 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me entity There's a new configuration option in the settings to allow sharing coupons between members of the same trading entity. It has to be in the base module for being shared between all the rest of applications, but each *_applicability module will contain extra bits of code to use it. TT45413
…main rule It is necessary to establish the default value, in this case "[ ]" to the rule_partners_domain field, in the create method for the rules established in the computed method "_program_type_default_values" that establishes the default values depending on the type of program, because when creating a new program, these rules do not have the rule_partners_domain field defined, as it is not contemplated, its value will be "False", which cannot be interpreted as a correct domain. To avoid this error, the check is made in the create method and the correct value is added. TT44344
Currently translated at 100.0% (5 of 5 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-loyalty_partner_applicability Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-loyalty_partner_applicability/it/
arantxa-s73
changed the title
|
/ocabot migration loyalty_partner_applicability |
|
@arantxa-s73 It seems you miss migration commit (where at least version change should appear in) :
|
arantxa-s73
force-pushed
the
17.0-mig-loyalty_partner_applicability
branch
from
222a23b to
389f92b
Compare
| @@ -2,7 +2,8 @@ | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | |||
| { | |||
| "name": "Loyalty Partner Applicability", | |||
| "summary": "Enables the definition of a customer filter for promotion rules that will " | |||
| "summary": "Enables the definition of a customer filter for promotion " | |||
| "rules that will " | |||
| "only be applied to customers who meet the specified conditions in the filter.", | |||
| "version": "16.0.2.0.2", | |||
There was a problem hiding this comment.
The version must be 17
There was a problem hiding this comment.
Is modified in the following commit: [MIG] loyalty_partner_applicability: Migration to 17.0
There was a problem hiding this comment.
Right, I was confused about commit, sorry
Can you push again to be able to run runbot?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 17.0