-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] coupon_limit > loyalty_limit: Migration to version 16.0 #155
Conversation
8f8b9a5
to
091607b
Compare
091607b
to
ec5161a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a temporal reference to your dependency so we can se the whole picture: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)
thanks :) |
ec5161a
to
ee76982
Compare
Allow coupon_limit settings to be used by other loyalty modules
ee76982
to
588573f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some doubts though:
588573f
to
2fb49c7
Compare
@CarlosRoca13 take a look please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go :)
ping @pedrobaeza :D |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
/ocabot migration coupon_limit |
Congratulations, your PR was merged at e026465. Thanks a lot for contributing to OCA. ❤️ |
Renamed to loyalty_limit
cc @Tecnativa TT44319
@chienandalu @ernesto-garcia-tecnativa please review