Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] rma_repair: New module rma_repair #433

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Oct 21, 2024

This module allows to create a repair order from RMA and depends of the repair if it's success can return the article to customer otherwise make a refund or replace for a new product.

cc https://github.com/APSL 155856
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

Depends on:

@peluko00 peluko00 force-pushed the 17.0-add-rma_repair branch 3 times, most recently from 3266a81 to 80b5070 Compare October 21, 2024 11:31
@mpascuall
Copy link

Once you're into the repair order and click the rma button, it sends you to the rma tree. It would be better to send you directly to the rma order instead

@peluko00 peluko00 force-pushed the 17.0-add-rma_repair branch from 132160b to 91b7399 Compare October 22, 2024 09:40
@peluko00
Copy link
Author

Once you're into the repair order and click the rma button, it sends you to the rma tree. It would be better to send you directly to the rma order instead

Done, thanks for the annotation!

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00 peluko00 force-pushed the 17.0-add-rma_repair branch from 91b7399 to e20a88d Compare October 23, 2024 08:55
@peluko00
Copy link
Author

Can you take a look at this module @rousseldenis please.

@rousseldenis rousseldenis added this to the 17.0 milestone Oct 23, 2024
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

)

def action_view_repair_rma(self):
return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why limiting the view to the first RMA ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to link one rma with one repair and i think this is the right way

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about it?

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Some improvements

rma_repair/models/rma.py Outdated Show resolved Hide resolved
rma_repair/models/rma.py Outdated Show resolved Hide resolved
rma_repair/models/rma.py Show resolved Hide resolved
@peluko00 peluko00 force-pushed the 17.0-add-rma_repair branch from e20a88d to ab490bd Compare October 23, 2024 11:56
@peluko00
Copy link
Author

Code review. Some improvements

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants