-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] rma_repair: New module rma_repair #433
base: 17.0
Are you sure you want to change the base?
Conversation
3266a81
to
80b5070
Compare
Once you're into the repair order and click the rma button, it sends you to the rma tree. It would be better to send you directly to the rma order instead |
132160b
to
91b7399
Compare
Done, thanks for the annotation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
91b7399
to
e20a88d
Compare
Can you take a look at this module @rousseldenis please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
) | ||
|
||
def action_view_repair_rma(self): | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why limiting the view to the first RMA ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to link one rma with one repair and i think this is the right way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Some improvements
e20a88d
to
ab490bd
Compare
Done, thanks! |
This module allows to create a repair order from RMA and depends of the repair if it's success can return the article to customer otherwise make a refund or replace for a new product.
cc https://github.com/APSL 155856
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review
Depends on: