Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [MIG] report_xml: Migration to 17.0 #824

Merged
merged 62 commits into from
Feb 5, 2024
Merged

[17.0] [MIG] report_xml: Migration to 17.0 #824

merged 62 commits into from
Feb 5, 2024

Conversation

anikeenko-viktor
Copy link

No description provided.

@pedrobaeza
Copy link
Member

Please check missing pre-commit changes in the last commit.

/ocabot migration report_xml

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 7, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 24, 2023
Open
25 tasks
@anikeenko-viktor anikeenko-viktor force-pushed the 17.0-mig-report_xml branch 2 times, most recently from 7d3d3c0 to 242ca65 Compare December 7, 2023 14:31
john-herholz-dt
john-herholz-dt approved these changes Dec 21, 2023
View reviewed changes
Copy link

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Jairo Llopis and others added 22 commits January 18, 2024 18:26
@aisopuro
Add module report_xml.
75e9e5c
@aisopuro
Add template utf8_header.
dfd9fa0 
Almost any XML must start with this. Let's make it easier.
@aisopuro
Easier XSD checking reports.
decc338 
Any report inheriting this AbstractModel can check its XML results
against any XSD.
@aisopuro
Add sample module.
014338d
@aisopuro
Sort links.
64d49e8
@aisopuro
Fix XML tag mismatch.
92d9774
@aisopuro
Allow docargs to be loaded from context.
4b88458
@aisopuro
Only replace the docs key if it is missing.
191a6bb
@aisopuro
Clearer code comments, add logging.
ae1f85d
@aisopuro
Oops, this header belongs to other module.
3465636
@aisopuro
Add module report_xml_sample.
3aa1597
@aisopuro
Clean AGPL garbage preserving copyright.
e6c0d1d 
See odoo/odoo@0bd4545.
@aisopuro
Return supers.
a2a793a
@aisopuro
Credit creators, using same name across modules to avoid split statis…
26ba469 
…tics.
@sbidoul @aisopuro
prefix versions with 8.0
860f135
@etobella @aisopuro
[MIG] report_xml: Migration to 10.0
8900769
@oca-transbot @aisopuro
OCA Transbot updated translations from Transifex
62e8f5d
@etobella @aisopuro
[MIG] report_xml: Migration to 11.0
c17f6fc
@oca-transbot @aisopuro
OCA Transbot updated translations from Transifex
4327557
@naglis @aisopuro
[IMP] report_fillpdf, report_xlsx, report_xml: Use content_dispositio…
f26ad34 
…n helper
@tarteo @aisopuro
[FIX] report_xml readme
537b5b8
@oca-travis @aisopuro
[UPD] Update report_xml.pot
8db13ed
Du-ma and others added 14 commits January 18, 2024 18:26
@Du-ma @aisopuro
[MIG] report_xml: Migration to 16.0
bd0de63
@aisopuro
[UPD] Update report_xml.pot
23b08f8
@OCA-git-bot @aisopuro
[UPD] README.rst
6f085a7
@weblate @aisopuro
Update translation files
61b8c0c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_xml/
@OCA-git-bot @aisopuro
[IMP] update dotfiles [ci skip]
8a1fe58
@Mantux11 @aisopuro
[16.0][IMP] report_xml: Added xml_extension
01a303c 
Adds a way to choose the file extension for your XML file, by adding the flexibility of appending more choices.
For example, instead of getting `.xml`, this allows to have the report download as `.svg` or even good old `.html` if needed.
This is also very useful for some localization purposes, where some scarce software uses uncommon file extensions for their XML files, like `.ffdata` for specific accounting reports here in Lithuania.

The change is not breaking, as we set the default to be `.xml` like it was by default anyway.
@aisopuro
[UPD] Update report_xml.pot
b84f60a
@OCA-git-bot @aisopuro
report_xml 16.0.1.1.0
91fe582
@weblate @aisopuro
Update translation files
95937f0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_xml/
@OCA-git-bot @aisopuro
[UPD] README.rst
71640d6
@TennyMkt @aisopuro
fix for report.py per docids = none
ec6045e
@OCA-git-bot @aisopuro
[BOT] post-merge updates
e802688
@viktor-anikeenko-avsys @aisopuro
[IMP] report_xml: pre-commit auto fixes
6dd4fd3
@viktor-anikeenko-avsys @aisopuro
[MIG] report_xml: Migration to 17.0
cefc885
@aisopuro aisopuro force-pushed the 17.0-mig-report_xml branch from 242ca65 to cefc885 Compare January 18, 2024 16:36
@aisopuro
Copy link
Contributor

I rebased this migration on top of 17.0 and resolved the conflict in requirements.txt (it had been updated in a previously merged PR it seems).

All checks are passing now, can @gurneyalex or @john-herholz-dt recheck and merge? The only change should be that requirements.txt now includes the requirments of previously merged modules.

john-herholz-dt
john-herholz-dt approved these changes Jan 18, 2024
View reviewed changes
Copy link

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I did also a functional test on runboat.
Got the demo report as expected.

Approved!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@aisopuro
Copy link
Contributor

@gurneyalex @john-herholz-dt is there something more that I need to do, or anything I can do to help get this merged? I don't mean to spam messages, I'm just worried this slipped through the cracks somewhere.

@john-herholz-dt
Copy link

@gurneyalex regarding last message. Can you confirm my knowledge of the merge process:
When PR is labeled ready to merge, a maintainer gets notified and needs to run the OCABOT merge command, right?

When the maintainer does not respond, the only option is to ping the person?

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-824-by-gurneyalex-bump-nobump, awaiting test results.

@gurneyalex
Copy link
Member

@aisopuro no pb. It sometimes takes a little bit of time until someone can get back to the PR and merge it.

@john-herholz-dt that's it yes.

@OCA-git-bot OCA-git-bot merged commit 72cbf09 into OCA:17.0 Feb 5, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8986d1d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@john-herholz-dt john-herholz-dt john-herholz-dt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.